[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#998397: marked as done (FTBFS: very wrong python dependency)

Your message dated Wed, 03 Nov 2021 17:35:35 +0000
with message-id <E1miKAh-000F2l-EF@fasolo.debian.org>
and subject line Bug#998397: fixed in python-botocore 1.22.9+repack-1
has caused the Debian Bug report #998397,
regarding FTBFS: very wrong python dependency
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
998397: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=998397
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: assimp
Version: 5.0.1~ds0-3
Tags: patch
Control: clone -1 -2
Control: retitle -2 rules-require-build-prerequisite gives bogus advice
Control: reassign -2 lintian
Control: severity -2 important
Control: tags -2 - patch
Control: affects -2 src:assimp
User: debian-cross@lists.debian.org
Usertags: ftcbfs
X-Debbugs-Cc: debhelper@packages.debian.org
X-Debbugs-Cc: debian-cross@lists.debian.org

assimp fails to cross build from source. It attempts to build a python
module, but it ultimately fails doing so. While inspecting this, I
discovered that assimp "Build-Depends: python3:any | python3-all:any |
python3-dev:any | python3-all-dev:any | dh-sequence-python3". This is
wrong on so many levels.

For starters, sbuild ignores any alternative in unstable, so in
practice, this happens to become "python3:any". Any other alternative is
simply ignored and shouldn't be there.

Then, issuing a dependency on python3-dev:any without libpython3-dev is
practically never correct. That could be a separate lintian tag, but
that's not too bad here as python3-dev isn't needed. Either you go
python3-dev or you go python3-dev:any, libpython3-dev or you have a very
special and unusual use case that I have never encountered anywhere.

Also listing dh-sequence-python3 there is bogus. You already added
"--with python3" in debian/rules. This is duplicate at best. Either
should be dropped, but enabling a dh-addon in an alternative is clearly
not right, and debhelper should likely fail hard when encountering that.
Niels, do you agree?

I wondered how one would come up with such a strange dependency and
asked #debian-mentors for help. Kindly, a user named "itd" pointed me at
the lintian tag rules-require-build-prerequisite, which very likely is
the cause for this. Please disable the tag right now as it does more
harm than good. While the tag isn't bad per-se, the advice it gives
misleads users and produces broken packages. I request hiding or
disabling it now and then figuring out what it really should say.

Back to assimp. I looked into this to make it cross buildable, right?
And it was failing in Python-ish stuff. So why do we actually build the
Python module? Did I say module? It's not an extension? No, it isn't.
And we really don't have to build it in an arch-only build. So the key
to making assimp cross buildable is to make an arch-only build fully
skip the Python stuff. And once you do that, you don't care about :any
annotations anymore as those are practically irrelevant in
Build-Depends-Indep.

So I've attached a patch for assimp to fix the cross build and the
strange build dependency. Please consider applying it.

Helmut

diff --minimal -Nru assimp-5.0.1~ds0/debian/changelog assimp-5.0.1~ds0/debian/changelog
--- assimp-5.0.1~ds0/debian/changelog	2021-10-06 09:02:14.000000000 +0200
+++ assimp-5.0.1~ds0/debian/changelog	2021-10-08 20:49:28.000000000 +0200
@@ -1,3 +1,15 @@
+assimp (5.0.1~ds0-3.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix python build dependency. (Closes: #-1)
+    + Alternatives in Build-Depends are ignored.
+    + Enable the python3 dh addon once only.
+    + Build python module in indep build only.
+    + Move python Build-Depends to B-D-I.
+    + Drop the :any nonsense.
+
+ -- Helmut Grohne <helmut@subdivi.de>  Fri, 08 Oct 2021 20:49:28 +0200
+
 assimp (5.0.1~ds0-3) unstable; urgency=medium
 
   [ Debian Janitor ]
diff --minimal -Nru assimp-5.0.1~ds0/debian/control assimp-5.0.1~ds0/debian/control
--- assimp-5.0.1~ds0/debian/control	2021-10-06 09:02:14.000000000 +0200
+++ assimp-5.0.1~ds0/debian/control	2021-10-08 20:49:28.000000000 +0200
@@ -15,8 +15,10 @@
  libstb-dev,
  libutfcpp-dev,
  zlib1g-dev | libz-dev,
- python3:any | python3-all:any | python3-dev:any | python3-all-dev:any | dh-sequence-python3,
  doxygen,
+Build-Depends-Indep:
+ dh-sequence-python3,
+ python3,
 Rules-Requires-Root: no
 Vcs-Git: https://salsa.debian.org/debian/assimp.git
 Vcs-Browser: https://salsa.debian.org/debian/assimp
diff --minimal -Nru assimp-5.0.1~ds0/debian/rules assimp-5.0.1~ds0/debian/rules
--- assimp-5.0.1~ds0/debian/rules	2021-10-06 09:02:14.000000000 +0200
+++ assimp-5.0.1~ds0/debian/rules	2021-10-08 20:49:28.000000000 +0200
@@ -33,7 +33,7 @@
 export PYBUILD_NAME=pyassimp
 
 %:
-	dh $@ --with python3 --buildsystem=cmake
+	dh $@ --buildsystem=cmake
 
 override_dh_auto_configure:
 	dh_auto_configure -- \
@@ -50,8 +50,10 @@
 
 override_dh_auto_build:
 	dh_auto_build
+ifneq ($(filter python3-pyassimp,$(shell dh_listpackages)),)
 	dh_auto_build --buildsystem=pybuild -- \
 		-d port/PyAssimp/
+endif
 	cd obj-$(DEB_HOST_GNU_TYPE)/doc && doxygen Doxyfile
 	cd doc && doxygen Doxyfile_Cmd
 
@@ -61,8 +63,10 @@
 
 override_dh_auto_install:
 	dh_auto_install
+ifneq ($(filter python3-pyassimp,$(shell dh_listpackages)),)
 	dh_auto_install --buildsystem=pybuild -- \
 		-d port/PyAssimp/
+endif
 	# IrrXML is not packaged for Debian, so drop the wrapper
 	find debian/*/usr -name irrXMLWrapper.h -delete

--- End Message ---
--- Begin Message --- 
Source: python-botocore
Source-Version: 1.22.9+repack-1
Done: Noah Meyerhans <noahm@debian.org>

We believe that the bug you reported is fixed in the latest version of
python-botocore, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 998397@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Noah Meyerhans <noahm@debian.org> (supplier of updated python-botocore package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 03 Nov 2021 10:21:57 -0700
Source: python-botocore
Architecture: source
Version: 1.22.9+repack-1
Distribution: unstable
Urgency: medium
Maintainer: Debian Cloud Team <debian-cloud@lists.debian.org>
Changed-By: Noah Meyerhans <noahm@debian.org>
Closes: 998397
Changes:
 python-botocore (1.22.9+repack-1) unstable; urgency=medium
 .
   * New upstream version 1.22.9+repack
   * Fix python build dependency (Closes: 998397)
   * Refresh patch 0001-Don-t-use-duplicated-modules.patch
Checksums-Sha1:
 dded600ed6df0422d91639b4faf0965612ff4838 2153 python-botocore_1.22.9+repack-1.dsc
 02a2f21b74d5d14224e5cc50bcd8712260504575 4760936 python-botocore_1.22.9+repack.orig.tar.xz
 84198ae00eccf95cae042d455952023698304c37 5992 python-botocore_1.22.9+repack-1.debian.tar.xz
 178e8dcb2b9a3accf8e123c1b6afd14bc4dbaa8d 6396 python-botocore_1.22.9+repack-1_source.buildinfo
Checksums-Sha256:
 1d51ed83b8d6b48026baaca2663d4a92c085d6793019e43ab77accce9033ba53 2153 python-botocore_1.22.9+repack-1.dsc
 c3d172c12e636fae5ad0acdfed22d0a139ce3a84cf8992285e3133f29241dc25 4760936 python-botocore_1.22.9+repack.orig.tar.xz
 ad5bbdf5b4b9e209715b20d469c35aefd03fff64fac4591ea6b3bd2ebce56a2e 5992 python-botocore_1.22.9+repack-1.debian.tar.xz
 a51821e0d4a71b0110f6c665d8b26e43716e818033c231b203ec5d9fe95d461f 6396 python-botocore_1.22.9+repack-1_source.buildinfo
Files:
 04d87b949cb4fe04d74ff7963eb261f7 2153 python optional python-botocore_1.22.9+repack-1.dsc
 2ca39fabd8aa5e05fe9b707ad972ad21 4760936 python optional python-botocore_1.22.9+repack.orig.tar.xz
 a075dc19add99129fa3b37a46070b395 5992 python optional python-botocore_1.22.9+repack-1.debian.tar.xz
 5b5a2acbf99e05caac52130f9a928986 6396 python optional python-botocore_1.22.9+repack-1_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJFBAEBCgAvFiEE65xaF5r2LDCTz+zyV68+Bn2yWDMFAmGCxhgRHG5vYWhtQGRl
Ymlhbi5vcmcACgkQV68+Bn2yWDMHLw//ePXV1jovse4TtBpWiFUKVaWJIQV0WvK7
xg+Ku2zA0yMlLYw21ihyZu5hAYtDlpS5qXRAp7nfOytjZyMn8AFprJfQESUn0BPn
VTcspM7D+k7TlqX5c57nMzVCL6jQukCkn4tnPCVKikamvtGJm/Zteh9H5SSuLNeW
ZM/prFBnsQdhZiYuRON42FlS/fN9gqHXLO/EhtkdOFR2gcQGNm3Ct1jw8pfrXMf0
yY4ClxdWV6RCeHj+nH3i5rG5+3M/KdQ9snJOnIIJskStSMOvWo6GUOppNcGfUgtB
OWYCUh8nm7L7pxL7rKP5lNUB7pjl/X9s/xwekDd3qttE51x/xLRZ8BY/7lWSHKaz
7DzpxzDTNEEL44UbTrbZUQ7wAJFw6ihEY44KqF5gMypX/YjhsTYFPxAY7P4nJ3FN
tV6cmiE+rPn2UDUlz9QdulMb/mm5g9sWczJ6FE/+nQ4Lqu7INTMvzNPReXA6Nhx2
1/8BWUHm7H4hvc/6cRIJfOIiiLUK3krURa9XrFCKhnouX7r1ZjaTaXc2XQgZqrgb
WpVJO/RjJ3g4KLN79NsSmdNe61WI32lcHJ66x6sbO7OntvmqU7DQolG2ukC6j0aV
IM877aDGCgZekItUCWSD96ZM5Ip5B5RFQxU1R9jkMzwHmXmAyb4bvQC8Ulx8/ler
nSLRpbRugRE=
=+kHe
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: