Re: Bug#947351: cloud-init 20.2-2~deb10u1 flagged for acceptance
On Tue, 2020-08-18 at 20:46 +0100, Adam D. Barratt wrote:
> On Tue, 2020-08-18 at 12:31 -0700, Stefano Rivera wrote:
> > Before 19.2 cloud-init wrote /etc/network/interfaces.d/50-cloud-
> > init.cfg
> > After 19.2 cloud-init wrote /etc/network/interfaces.d/50-cloud-init
> > Relevant upstream commit:
> > https://github.com/canonical/cloud-init/commit/a6faf3acef02bd8cd4d46ac9efeebf24b3f21d81
>
> I must admit that I'm slightly confused by that commit.
>
> The rationale is that the default file written by ifupdown uses
> "source-directory", which will not read foo.cfg. However, the commit
> that it points to clearly shows that the "source" directive is used
> instead, and the manpage (as also pointed to by the cloud-init
> commit) does not suggest that any such naming restriction applies to
> "source", so far as I can see.
Looking further, it appears that the current release of ifupdown *does*
actually use "source-directory", but the version in git doesn't - both
for consistency with the interfaces file that d-i generates, and to
avoid exactly this kind of bug. :-m [
https://salsa.debian.org/debian/ifupdown/-/merge_requests/4 ]
While the ifupdown change was only merged fairly recently, the MR
suggesting the change was filed two months /before/ the upstream change
was made. On that basis, I continue to be inclined to think that this
should be reverted in unstable (and possibly upstream).
Regards,
Adam
Reply to: