Re: image-finder | Remove unnecessary modules (!30)
On 7/30/19 3:27 PM, Arthur Diniz wrote:
> Hi Thomas,
>
> Analyzing the issue [1]that Bastian had created would require the use of
> a setup.py file.
> This file already stores all application dependencies without having a
> requirements.txt file.
Arthur,
I'm sorry, but maybe are mistaking here. I believe I explained it to you
already in Curitiba (but probably we had too many beers? :)). My
intention was to use pbr, so that there's no need to to express the
dependencies in setup.py, as everything would be automated by PBR, and
all would be written decoratively either in requirements.txt /
test-requirements.txt, and in setup.cfg.
> So the reason I closed this MR [2] was that to move faster I joined the
> part that you had done
> regarding the dependency clean with this new configuration file in a new
> MR [3].
Please do not merge [3], writing things as a program in setup.py is very
much inferior to what you can achieve with PBR. I am volunteering to do
this work myself, but I need the requirements patch to be merged first.
You also need to move all of your source files inside a folder, so that
it's easier to do the python packaging. I strongly recommend that you do
not remove the tests as you did in the setup.py (ie: the "exclude=
thing), and that you also move the tests folder inside your main package
folder, so that everything gets packaged, including tests.
As soon as you've done that, I'll write a setup.py / setup.cfg for your
application. As I told you, this includes the wsgi file, if you can tell
me what python path I should use (something like: debimgfinder.web:main,
if you decide for example to use deimgfinder/web.py with a function
called main inside that file).
> I created an issue [4] to track the remaining modules to be wrapped for
> Debian.
Psycopg2 is already in Debian, no need to package it, it's been there
for years. :)
Also, what's the advantage of using flask-migrate rather than just
alembic directly? I don't know this module, can you explain?
Thanks for your work, I'm very much looking forward see progress on this
project, Cheers,
Thomas Goirand (zigo)
Reply to: