[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#887226: cloud-init should depend on e2fsprogs explicitly

Control: severity -1 minor
Control: retitle -1 cloud-init should consider suggesting e2fsprogs, btrfs-progs, xfsprogs, ...

On Sun, Jan 14, 2018 at 08:03:22PM +0100, Helmut Grohne wrote:
> Package: cloud-init
> /usr/lib/python3/dist-packages/cloudinit/config/cc_resizefs.py contains resize2fs. According to file it is a Python script, ASCII text executable

A code snippet from cc_resizefs.py:

def _resize_btrfs(mount_point, devpth):
    return ('btrfs', 'filesystem', 'resize', 'max', mount_point)

def _resize_ext(mount_point, devpth):
    return ('resize2fs', devpth)

def _resize_xfs(mount_point, devpth):
    return ('xfs_growfs', devpth)

def _resize_ufs(mount_point, devpth):
    return ('growfs', devpth)

# Do not use a dictionary as these commands should be able to be used
# for multiple filesystem types if possible, e.g. one command for
# ext2, ext3 and ext4.
    ('btrfs', _resize_btrfs),
    ('ext', _resize_ext),
    ('xfs', _resize_xfs),
    ('ufs', _resize_ufs),


Given that cloud-init package doesn't specify a relationship to any
of the other filesystem specific packages shipping resizing tools
I'm going to assume there's no need for e2fsprogs relationship either.
It probably wouldn't hurt to add atleast a Suggests for all of them

Would be great to hear the maintainers view on this.

Andreas Henriksson

Reply to: