[review] waagent: Windows Azure Linux Agent (part4)
Hi Arnaud,
On Mon, 10 Dec 2012 16:44:17 +0100
Arnaud Patard <apatard@hupstream.com> wrote:
> submitted as bug #695575.
more fix
- it's python script, so Arch should be all
- it fails to setup without /sbin/route that is provided by net-tools
(thanks to piuparts)
- removing package fails with sudo, however it seems that sudo package's problem
- can improve prerm/postrm script
diff -Nru waagent-1.2/debian/control waagent-1.2/debian/control
--- waagent-1.2/debian/control 2012-12-10 19:25:16.000000000 +0900
+++ waagent-1.2/debian/control 2012-12-16 23:51:32.000000000 +0900
@@ -8,8 +8,8 @@
Package: waagent
-Architecture: amd64
-Depends: ${misc:Depends}, ${python:Depends}, iptables, openssh-server, openssl, sudo
+Architecture: all
+Depends: ${misc:Depends}, ${python:Depends}, iptables, openssh-server, openssl, sudo, net-tools
Conflicts: network-manager
Description: Windows Azure Linux Agent
The Windows Azure Linux Agent (waagent) manages VM interaction with the Windows
In debian/prerm
> if [ -f /var/log/waagent.log ]; then
> rm -f /var/log/waagent.log
> fi
not need to remove log files
and it can be simplified as below
------------------------------------------------------
files="/etc/waagent.conf \
/etc/logrotate.d/waagent \
/etc/sudoers.d/waagent \
/var/lib/waagent"
for file in files
do
if [ -f $file ]; then
rm -f $file
elif [ -d $file ]; then
rm -rf $file
fi
done
------------------------------------------------------
and it seems to be that waagent itself also has "delete" function, so
I doubt it should be done in maintainer script or not...
--
Regards,
Hideki Yamane henrich @ debian.or.jp/org
http://wiki.debian.org/HidekiYamane
Reply to: