[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1079611: marked as done (cjs: Please don't build-depend on dbus-x11)

Your message dated Fri, 06 Sep 2024 11:51:56 +0000
with message-id <E1smXVM-00CA0j-Mq@fasolo.debian.org>
and subject line Bug#1079611: fixed in cjs 6.2.0-2
has caused the Debian Bug report #1079611,
regarding cjs: Please don't build-depend on dbus-x11
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1079611: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1079611
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: cjs
Version: 6.2.0-1
Severity: normal
Tags: patch
User: dbus@packages.debian.org
Usertags: dbus-launch dbus-launch-for-tests

cjs relies on dbus-launch (dbus-x11) to run its test suite, but it
doesn't need to: dbus-run-session (dbus-daemon) is sufficient. Please
consider the attached patch, similar to one that I sent for gjs.

See also <https://lists.debian.org/debian-devel/2016/08/msg00554.html>,
a mass bug filing in 2016.

The autopkgtests still pass with the attached patch (tested in qemu,
lxc, podman).

I didn't try cjs 6.0 (in testing/unstable) but I suspect that the same
patch would be equally valid there.

Thanks,
    smcv

>From 9c592ca6b8ba802be4a9d2cc8772a6baf19d3b95 Mon Sep 17 00:00:00 2001
From: Simon McVittie <smcv@debian.org>
Date: Sun, 25 Aug 2024 10:57:02 +0100
Subject: [PATCH] Run tests using dbus-run-session instead of dbus-x11

This avoids pulling in backwards-compatibility code in
/etc/X11/Xsession.d.

Closes: #-1
---
 debian/control       | 1 -
 debian/rules         | 1 +
 debian/tests/control | 2 +-
 3 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/debian/control b/debian/control
index 44bbbc09..745b59b8 100644
--- a/debian/control
+++ b/debian/control
@@ -11,7 +11,6 @@ Uploaders:
 Build-Depends:
  at-spi2-core <!nocheck>,
  dbus-daemon <!nocheck>,
- dbus-x11 <!nocheck>,
  debhelper-compat (= 13),
  dh-sequence-gir,
  dh-sequence-gnome,
diff --git a/debian/rules b/debian/rules
index 32e22fd1..f6ad3b01 100755
--- a/debian/rules
+++ b/debian/rules
@@ -39,6 +39,7 @@ override_dh_auto_test:
 	obj-$(DEB_HOST_GNU_TYPE)/cjs-console -c 'print("Smoke-test OK")'
 	env \
 		TZ=UTC \
+	dbus-run-session -- \
 	xvfb-run -a \
 	dh_auto_test -- -v -C $(CURDIR)/obj-$(DEB_HOST_GNU_TYPE) --timeout-multiplier 4
 
diff --git a/debian/tests/control b/debian/tests/control
index f341a109..640f6ddf 100644
--- a/debian/tests/control
+++ b/debian/tests/control
@@ -7,5 +7,5 @@ Depends: libcjs-dev, build-essential
 Restrictions: superficial
 
 Tests: installed-tests
-Depends: dbus-daemon, dbus-x11, cjs-tests, gnome-desktop-testing, xauth, xvfb
+Depends: dbus-daemon, cjs-tests, gnome-desktop-testing, xauth, xvfb
 
-- 
2.45.2

--- End Message ---
--- Begin Message --- 
Source: cjs
Source-Version: 6.2.0-2
Done: Fabio Fantoni <fantonifabio@tiscali.it>

We believe that the bug you reported is fixed in the latest version of
cjs, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1079611@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Fabio Fantoni <fantonifabio@tiscali.it> (supplier of updated cjs package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 06 Sep 2024 13:30:32 +0200
Source: cjs
Architecture: source
Version: 6.2.0-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Cinnamon Team <debian-cinnamon@lists.debian.org>
Changed-By: Fabio Fantoni <fantonifabio@tiscali.it>
Closes: 1079611
Changes:
 cjs (6.2.0-2) unstable; urgency=medium
 .
   [ Simon McVittie ]
   * Run tests using dbus-run-session instead of dbus-x11 (Closes: #1079611)
 .
   [ Fabio Fantoni ]
   * Add d/README.source with a wiki link with details about packaging
   * d/control: replace pkg-config with pkgconf
   * Update standards version to 4.7.0, no changes needed
   * Release to unstable
Checksums-Sha1:
 ee18402b3552fcfcee6b18ef6395632d601a8261 2659 cjs_6.2.0-2.dsc
 fc3cd7e030fb4e320a4ff3162bd75a83e1d72155 873983 cjs_6.2.0.orig.tar.gz
 315f4d2e34a62054ec1266da9c23309a12da727e 10928 cjs_6.2.0-2.debian.tar.xz
 558304f21a136053a93fa2f824cf911dd12cbe05 15077 cjs_6.2.0-2_source.buildinfo
Checksums-Sha256:
 354ab0dc6065acc65e1587f7f0b4b047d6aa2d93bbb4033eeb6f6c6723dcac2e 2659 cjs_6.2.0-2.dsc
 e5c22a58b1201d242ffbc22225eaa59109c662fa01d04ca6e755768976a92661 873983 cjs_6.2.0.orig.tar.gz
 ce3caf326ac9a3e7a3e17b15a26be2c6c696e1821622b4d023e854096ba22b83 10928 cjs_6.2.0-2.debian.tar.xz
 9f7b80183e08f10c82a218d69a6c2e39adbb62840e043ae9cfc5adc1c7310bd7 15077 cjs_6.2.0-2_source.buildinfo
Files:
 8a77c351dfd05626202137ca28fc5237 2659 interpreters optional cjs_6.2.0-2.dsc
 ed48a133716ee0349cc3b291f4a11f1f 873983 interpreters optional cjs_6.2.0.orig.tar.gz
 2b7cecdf4a50340b182c66c051b10f8c 10928 interpreters optional cjs_6.2.0-2.debian.tar.xz
 86d3b75e8005581a6be6eab776017e9b 15077 interpreters optional cjs_6.2.0-2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEELEHRfLe4S9D5+1GzaAZorpB/EB0FAmba6H8ACgkQaAZorpB/
EB03OA//W3ygaXPilfV2WCOf2f4N3/mU9mF68b2HJqejI8Ot6DpCSgFRQ4VL3Vmh
rN3fx3oc8Lw25GAWPi9MiH3Kp05BZVMqw3TJBiN8w5/L6X9TTmeSVLBOYBtpXyaO
pgAyA98gE/DnOwksh+9UkjTA1Vdfzev+OJ4py2AqZbrjPrtwJ8PhU0gknRFGOcle
0VyVDrwNeojKbPWTP5j33np5FeYCqIz0SMaP0vtcTX0S6O/Q0UOSJbeW1W8oFNtH
6NI/pRqHyfB25aWJd49HfSq0P0WnwA/e6efZix0eRBwL0PlZcqHAmeoHYm47mHgl
eJ8KqZVitJapwYgYKSWdoYyZ/YUvIjJbEut2fpRrG+AR6MfLU3KH6/+37N5IHq0R
wvDh4LIvn6yDHuOaiJ8CEQQEqN9JDiZKm7zA2mCL+7jWiJyyibLLuZ4fNubWpn7O
/A5hwm2aii+GPoM8GwhXscdF5GOH81n/7ogT9NWOArltnd9ZTb7wTY3h8okWRKgP
tgDlBfEAO+xWB/p7M42XE9WrpB8/IzU9O/271sri/GngE9YNX6b/inBqBKoZ+hGL
vbk+UksAz+8NqrDC2DKJbCZr+V3r3sJGfJ2qVUISGWxAY906HeCzkH6q5gZmPUJz
v5Icaq8IrIR3qEufP5E2Lmq2MIryo+s0mTLPY29FOYm/XcjQUgs=
=Ehfo
-----END PGP SIGNATURE-----

Attachment: pgptyZe9RM9in.pgp
Description: PGP signature


--- End Message ---
Reply to: