Bug#1037940: port-to-libsoup3.patch looks bad
Package: libtimezonemap1
Version: 0.4.6-5
X-Debbugs-CC: itzswirlz2020@outlook.com
Hi maintainers, somebody noticed that you had ported libtimezonemap to
libsoup 3 and I was asked to look into whether the patch would be good
for Fedora or upstream. I noticed several problems. (1) The patch casts
a const char* to a GUri*. That's not going to work. (2) It also frees a
GAsyncResult using an incorrect free function, g_free() when it should
be g_object_unref(). (3) It casts a SoupMessage to a SoupSession, which
won't work. (4) The call to soup_session_get_async_result_message()
looks like it wouldn't do anything even if it was called with a
SoupSession rather than a SoupMessage.
I'm excited to see more libsoup 3 porting, but I recommend dropping
this patch. I see it has not yet graduated from experimental to sid, so
that's good.
Reply to: