[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Cinnamon 4.8 in experimental



Il 05/12/2020 17:51, Fabio Fantoni ha scritto:
> Il 05/12/2020 14:25, Norbert Preining ha scritto:
>> Hi Fabio,
>>
>> On Sat, 05 Dec 2020, Fabio Fantoni wrote:
>>>> * Concerning cinnamon on mips64el
>>>> ../src/cinnamon-global-private.h:23:10: fatal error: cinnamon-enum-types.h: No such file or directory
>>>>    23 | #include "cinnamon-enum-types.h"
>>>>       |          ^~~~~~~~~~~~~~~~~~~~~~~
>>>> very strange again.
>>> From a fast look a bump (to 4.8) in build-dep of gir1.2-meta-muffin-0.0
>>> and  libmuffin-dev is missed and upstream have other build related fixes
>>> after 4.8.0
>> No, that shouldn't be the problem. cinnamon-enum-types.h comes from
>> 	cinnamon.git/src/cinnamon-enum-types.h.in
>> so this is a header that is provided - or should be provided - by the
>> cinnamon package itself. We need to check **why** it was not generated
>> on mips64el, but I *don't* think it is related to muffin.
> there other build fixes upstream other that nm dep:
> https://github.com/linuxmint/cinnamon/commit/244fe7893d11ec92b507090eb0b40dc9679c6639
> https://github.com/linuxmint/cinnamon/commit/1b52e96ecf499f1a7d7c8c71c1aff39d88dca04d
>
> I'll do a commit with it and other patch about nm

Done
https://salsa.debian.org/cinnamon-team/cinnamon/-/compare/5b6859c40a691e46b6a85ecde0592e420050c1ec...0a6f11a2dc1a1cc25137ebde65981ea81b0cf75b

i386 build was still fails
(http://debomatic-i386.debian.net/distribution#experimental/cinnamon/4.8.0-2~/buildlog),
solved removing override_dh_girepository (also upstream don't have it):
http://debomatic-i386.debian.net/distribution#experimental/cinnamon/4.8.0-2~1/buildlog

I did all good?

>
>>>> ... NM ...
>>> The non linux (FWIR) don't have it and that should be solved adding the
>>> patch above and in debian/rules use it with "ifneq (,$(filter
>>> linux,$(DEB_HOST_ARCH_OS)))", or I'm wrong?
>> The patch from the git repo you linked? I guess I wait for the next
>> release for it ...
>>
>> And, using
>> 	ifneq (,$(filter linux,$(DEB_HOST_ARCH_OS)))
>> where do you want to use it?
>>
>> Please, commit changes as necessary, including a patch from the
>> mentioned commit, if you think that helps. I am not sure at all.
>>
>> Best
>>
>> Norbert
>>
>> --
>> PREINING Norbert                              https://www.preining.info
>> Accelia Inc. + IFMGA ProGuide + TU Wien + JAIST + TeX Live + Debian Dev
>> GPG: 0x860CDC13   fp: F7D8 A928 26E3 16A1 9FA0 ACF0 6CAC A448 860C DC13
>>


Reply to: