Re: cinnamon 4.4

[Norbert Preining <norbert@preining.info>]

Hi Fabio,

> About pango 1.44 I looked this commit:
> https://github.com/linuxmint/nemo/commit/dcc5134c10417262b74de4f88883d9c086c92c4a
> From that patch seems that should support also older versions, or I'm wrong?

Hmmm, I just tried it and removed the version number from the B-D,
installed the version from unstable, and tried to build: During
configure I get:
	...
	Run-time dependency libselinux found: YES 3.0
	Dependency pango found: NO found '1.42.3' but need: '>=1.44.0'
	Found CMake: /usr/bin/cmake (3.15.4)
	Run-time dependency pango found: NO (tried pkgconfig and cmake)
	Has header "libintl.h" : YES 
	...

That comes from meson.build:
	new_pango = dependency('pango', version: '>=1.44.0', required: false)
	if new_pango.found()
	  conf.set('HAVE_PANGO_144', true)
	endif
which means it **only** checks for pango >= 1.44, but not for the
presence of a pango library with smaller version number. This is
strange, but well, so it be. Maybe it should be
	pango = dependency('pango', version: '>=1.42', required: true)
	new_pango = dependency('pango', version: '>=1.44.0', required: false)
	if new_pango.found()
	  conf.set('HAVE_PANGO_144', true)
	endif
??

Anyway, this is not *necessary* if we are sure that the pango dev stuff
is installed ...

Best

Norbert

--
PREINING Norbert                               http://www.preining.info
Accelia Inc. + IFMGA ProGuide + TU Wien + JAIST + TeX Live + Debian Dev
GPG: 0x860CDC13   fp: F7D8 A928 26E3 16A1 9FA0 ACF0 6CAC A448 860C DC13