Bug#975457: mandos: password-agent autopkgtest does not seem to be reliable

[Simon McVittie <smcv@debian.org>]

Source: mandos
Version: 1.8.12-1
Severity: serious
Justification: https://release.debian.org/bullseye/rc_policy.txt 6a
X-Debbugs-Cc: debian-ci@lists.debian.org

The password-agent autopkgtest doesn't seem to be stable: it sometimes
fails and sometimes succeeds. In
<https://ci.debian.net/packages/m/mandos/testing/amd64/> we can see that
around half the migration-reference tests in the last month have succeeded
and half have failed.

The end of the log from an example test failure is quoted below.

This can be a problem for the packages that it depends on, such as
glib2.0 and systemd: if the most recent migration-reference test happens
to have succeeded, but then the test with a proposed version of glib2.0
or systemd fails, then the testing migration infrastructure will assume
that it's a regression caused by glib2.0 or systemd.

If this test cannot be made reliable, please mark it with
"Restrictions: flaky" so that it will not be used as a migration gate.

Thanks,
    smcv

# Start of connect_question_socket tests
ok 117 /task/connect_question_socket/name-too-long
ok 118 /task/connect_question_socket/connect-fail
ok 119 /task/connect_question_socket/bad-epoll
ok 120 /task/connect_question_socket/usable
# End of connect_question_socket tests
# Start of send_password_to_socket tests
ok 121 /task/send_password_to_socket/client-not-exited
ok 122 /task/send_password_to_socket/password-not-read
Bail out! ERROR:dracut-module/password-agent.c:6020:test_send_password_to_socket_EMSGSIZE: 'string_set_contains(cancelled_filenames, question_filename)' should be TRUE
**
ERROR:dracut-module/password-agent.c:6020:test_send_password_to_socket_EMSGSIZE: 'string_set_contains(cancelled_filenames, question_filename)' should be TRUE
bash: line 1:  1815 Aborted                 bash -ec '/usr/lib/dracut/modules.d/90mandos/password-agent --test --verbose' 2> >(tee -a /tmp/autopkgtest-lxc.q6elt0p6/downtmp/password-agent-stderr >&2) > >(tee -a /tmp/autopkgtest-lxc.q6elt0p6/downtmp/password-agent-stdout)