[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#896023: Bug#901897 closed by Jonathan Nieder <jrnieder@gmail.com> (Bug#901897: fixed in git 1:2.18.0~rc2-2)

Hi Ian,

[Dropping bug 901897 as that has nothing to do with it; adding 896023 as
it is worth explaining it there if that bug isn't clear yet.]

On 22-06-18 12:45, Ian Jackson wrote:
> Paul Gevers writes ("Re: Bug#901897 closed by Jonathan Nieder <jrnieder@gmail.com> (Bug#901897: fixed in git 1:2.18.0~rc2-2)"):
>> And I just helped the test for git a bit as due to bug 896023 in
>> autopkgtest it didn't use the right autopkgtest from dgit.
> Thanks.
> It's not clear to me exactly what needed fixing.  Can you send me urls
> to the bad run which prompted your intervention, and the good run
> which resulted ?

[2] for the bad one. You already found the good one: [1].

> Looking here
>   https://qa.debian.org/excuses.php?package=git
> I see a migration test for git 1:2.18.0-1 which used dgit 5.1,
> despite the fact that dgit 5.1 is not in testing yet.

That was because of my intervention AND in [1] and because of the
appropriate Breaks in both [1] and [2].

> But that is appropriate, because the new git Breaks earlier versions
> of dgit.  AIUI britney will therefore not migrate the new git until
> the new dgit is migrated, which is correct.

Ack. That is why I allow myself to intervene in such a situation.

> Looking at the test log[1] it used the test suite from 5.1, too.

True, but ONLY because I told it so (you'll see that used 4.4 (as debci
reports) in [2]).

> I don't know how other packages do things, but in general, with dgit
> at least, mixing and matching program versions and test versions may
> work some of the time: particularly, newer programs will usually pass
> older tests.  Older programs will typically fail newer tests since the
> newer tests will look for new features.

This is very much not dgit specific. Today I had to do that for about 5
packages (coincidence, last two months I have done it about 15-20 times
or so). Autopkgtest doesn't detect that the installed version of the
package that it is testing is not the one that it was asked to test. It
must, and then start over again in some form with the test suite from
the right version.

> In this particular case: dgit 4.4's test suite will always fail with
> the new git.  dgit 5.1's test suite will properly test whether the
> tested dgit and git are compatible: so it will only fail with new git
> and old dgit.pass with old git; and with new git:
>    git              dgit test suite        dgit                result
>     1:2.17.1-1        4.4, 5.0, 5.1         4.4, 5.0, 5.1       PASS
>     1:2.18.0-1        <= 5.0                any                 FAIL
>     1:2.18.0-1        5.1                   <= 5.0              FAIL
>     1:2.18.0-1        5.1                   5.1                 PASS
> AFAICT from the migration information from britney from yesterday and
> today, all is fine except for git's an artificially inflated urgency.



> [1] https://ci.debian.net/data/autopkgtest/testing/amd64/d/dgit/491815/log.gz[2]

Attachment: signature.asc
Description: OpenPGP digital signature

Reply to: