Bug#868678: autopkgtest: Support Kali in setup-testbed

[hertzog@debian.org (Raphael Hertzog)]

On Wed, 09 Aug 2017, Martin Pitt wrote:
> Rapha?l Hertzog [2017-07-17 17:12 +0200]:
> > /usr/share/autopkgtest/setup-commands/setup-testbed rewrites
> > /etc/apt/sources.list in a way that only works with mirrors whose URL
> > contains "ubuntu" or "debian".
> > 
> > I would like the script to also work for Kali so I propose the following
> > patch:
> 
> Thanks! Applied to git.

Thanks but I would like you to consider my other suggestions in the same
report:

| But it should probably also be smarter for the benefits of all other derivatives:
| 
| - not do anything if $MIRROR or $RELEASE is empty
| 
| - rely on /etc/os-release (within the image) to identify the distribution and
|   use the first entry in /etc/apt/sources.list to find the mirror to use (that
|   way you can have a mirror like http://192.168.1.222:9999/ and still have a
|   working setup-testbed even if your ubuntu mirror does not contain the string
|   ubuntu)

I can understand the second one is a bit involved... but at least the first one is easy
to do. If you fail to identify the mirror or the release, don't overwrite the sources.list.

Please consider adding this. Thank you.

Cheers,
-- 
Rapha?l Hertzog ? Debian Developer

Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/