[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#823883: (no subject)

On Tue, May 10, 2016 at 10:49:16AM -0400, Barry Warsaw wrote:
> Looks like I could, so I did!
> I pushed a 'pypy' branch to git which, if not perfect, seems to work for me in
> some limited testing without breaking the existing test suite.  I'll attach a
> diff here for the fun of it.


> diff --git a/test/python_test.sh b/test/python_test.sh
> index 578a85f..79d9ce9 100644
> --- a/test/python_test.sh
> +++ b/test/python_test.sh
> @@ -16,6 +16,15 @@ test_python_detect_source_py3() {
>    assertTrue 'have py3 test' 'grep --quiet "print(" stdout'
>  }
> +# PyPy is only Python 2 compatible for now.
> +test_python_detect_source_pypy() {
> +  has 'debian/control' 'Source: python-foo\n\nPackage:pypy-foo'
> +  check_run autodep8
> +  assertTrue 'get upstream name' 'grep --quiet "import foo;" stdout'
> +  assertTrue 'have py2 test' 'grep --quiet "print " stdout'
> +  assertFalse 'dont have py3 test' 'grep --quiet "print(" stdout'
> +}

this test is indistinguishable from one that tests for python2 only ...
only now I noted that all of the python tests are inherentily flawed as
they are testing whether print is called with or without parenthesis,
instead of checking for what really matters, which is what interpreter
was actually called.

I fixed that in

would you mind rebasing your patch on top of the current master and
testing again?

Antonio Terceiro <terceiro at debian.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/autopkgtest-devel/attachments/20160511/1dab8e8d/attachment.sig>

Reply to: