[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#784942: autopkgtest: fails to read Files: from perfectly valid .changes file

Control: tag -1 pending

Hello all,

thanks for the .changes attachments! I can indeed reproduce this now.
Not under Ubuntu, as we have an older python3-debian (0.1.22) -- with
this version it works just fine. But I do get the error with
python3-debian 0.1.27 in sid.

Damyan Ivanov [2015-06-12 20:02 +0000]:
> Both .changes files seem to have what seems to be interpreted as 
> a comment. Lines 186-189 of /usr/share/autopkgtest/python/testdesc.py 
> seem to attempt to handle this, but after stripping the comment (not 
> starting from the first character), the resulting test seems to 
> confuse the parser, because the line now contains only whitespace.
> Perhaps the test on line 186 should also be triggered by lines 
> starting with whitespace,followed by #?

That's indeed the culprit. The workaround to filter out intra-line
comments (line 189) was necessary up to python-debian 0.1.22 due to
https://bugs.debian.org/743174 . 0.1.23 and later fixed some, but not
all, of this. But since autopkgtest needs to run on older releases
too, and even the latest python-debian doesn't accept all kinds of
comments I can't just drop this.

So I refined the parser now to handle lines which consist only of
whitespace and a comment, which seems to work well with older and
newer python-debian:


(including test case)


Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/autopkgtest-devel/attachments/20150615/e54dde84/attachment.sig>

Reply to: