[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

dpkg-source to automatically add a Testsuite field



On Sun, Jul 06, 2014 at 06:35:47PM +0200, Guillem Jover wrote:
> Hi!
> 
> Given that dpkg-dev has recognized the Testsuite field for some time,
> I don't really see a reason for dpkg-source not to automatically add
> it to the generated .dsc with an ?autopkgtest? value if there is a
> debian/tests/control file around, instead of requiring maintainers
> to remember to set it manually.

Quite a few maintainers already asked me why their packages weren't
being picked up by ci.debian.net, and when I went look at it, the reason
was that they forgot to add the Testsuite field to debian/control.
Having this automated in dpkg-source is really appreciated, thank you!

> Reading the spec [S], it seems to me that the file can be empty, as it
> states ?This is a file containing zero or more RFC822-style stanzas?,
> so the code cannot do any sanity check, like checking if the file
> contains one stanza with a Tests field. So it will only check for the
> file presence.
> 
>   [S] <https://anonscm.debian.org/gitweb/?p=autopkgtest/autopkgtest.git;a=blob;f=doc/README.package-tests.rst;hb=HEAD>
> 
> I've queued a patch doing exactly that for dpkg 1.17.11. If there's
> any known reservations with that, please speak up.

How will it handle an existing value in that field? In the future, we
might have other forms of test suite, thus requiring different items in
the Testsuite: field.  What happens when there is already

  Testsuite: foo

and dpkg-source detects the presence of debian/tests/control? Will it
merge `autopkgtest` into the list, or will it replace the existing
value?

-- 
Antonio Terceiro <terceiro at debian.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/autopkgtest-devel/attachments/20140707/0c36a9de/attachment.sig>


Reply to: