[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[PATCH 2/3] adt-run: add --upgrade-to option for upgrade tests



Hey Antonio,

Antonio Terceiro [2014-06-28 19:12 -0300]:
> > > +        upgrade = '((apt-get update || (sleep 15; apt-get update)) && apt-get dist-upgrade -y -o Dpkg::Options::="--force-confnew") 2>&1'
> > 
> > Aren't conffile prompts for unmodified packages something which
> > upgrade tests ought to detect? That's a rather important part of the
> > upgrade tests that we do in Ubuntu, as often config files become
> > conffiles (and cause a prompt), or vice-versa conffiles become
> > orphaned. At least the first case ought to be caught as conffile
> > prompts for (humanly) unmodified files are a nuisance and confusing.
> 
> TBH that bit was more or less just copied and pasted from what the
> --apt-upgrade option does so I didn't put much thought into this part
> yet. I should probably just drop the -o I guess?

Hm, on second thought I think this is right. We don't want to
eternally hang upgrades on a conffile prompt, we just want to register
it. Ubuntu's upgrade tests just check for the existance of *.dpkg-dist
files [1], I suppose we can rather do this, and keep the
--force-confnew? And perhaps fail the test if we run into any of them?

Thanks,

Martin

[1] http://bazaar.launchpad.net/~auto-upgrade-testing-dev/auto-upgrade-testing/trunk/view/head:/share/post_upgrade_tests/test_conffiles.py

-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/autopkgtest-devel/attachments/20140629/301509e2/attachment.sig>


Reply to: