Bug#1059858: debian-cd: Missing firmware packages due to usr-move

[Helmut Grohne <helmut@subdivi.de>]

Hi Emanuele,

On Tue, Jan 02, 2024 at 03:03:49PM +0100, Emanuele Rocca wrote:
> quite a few firmware packages are missing from today's debian-installer
> ISOs. Among the missing ones: firmware-atheros, firmware-realtek, and
> many others. Some firmware packages such as firmware-ath9k-htc and
> firmware-linux-free are instead present.
> 
> Packages correctly included in the ISOs ship firmware files under /lib,
> while those not included use /usr/lib. For example the following is
> included:
> 
>  firmware-linux-free: /lib/firmware/av7110/bootcode.bin
> 
> While missing packages install firmware files under /usr/lib:
> 
>  firmware-atheros: /usr/lib/firmware/wil6210.brd
> 
> It seems likely that tools/generate_firmware_task needs to be patched to
> take usr-move into account.

Yes, this very much looks like /usr-merge breakage and I fully agree
with the pointers you give. Just reading generate_firmware_task, the
contains_firmware sub immediately jumps into my eyes as the grep will
miss moved firmware packages. It should probably become

    grep ' \\./\\(usr/\\)\\?lib/firmware/'

(with the double escaping for the target context already applied).

I happen to not know how to test this though. Quite possibly, this is
not the only issue. Are you able to drive this forward from here?

Helmut