Bug#1056998: cdrom: Installation media changes after booting it

["Thomas Schmitt" <scdbackup@gmx.net>]

Hi,

i wrote:
> >Does any of the bystanders know from what package this message text stems ?

Steve McIntyre wrote:
> That's cdrom-checker:

So that would be indirectly put into the code at

  https://sources.debian.org/src/cdrom-checker/1.62/main.c/?hl=152#L152

by "Template: cdrom-checker/mismatch" in:

  https://sources.debian.org/src/cdrom-checker/1.62/debian/cdrom-checker.templates/?hl=43#L43

Using my micking instincts i guess my proposal would be to create a
new template like:

   Template: cdrom-checker/mismatch-efi
   Type: error
   # :sl3:
   _Description: Integrity test failed on EFI boot image
   The EFI boot image file ${FILE} failed the MD5 checksum verification.
   Possibly some software or firmware made changes in the EFI System
   Partition. This may be considered harmless unless booting of this
   Debian ISO encounters difficulties or other files show checksum
   mismatches, too.

and to add a case in main.c, line 151, like (shown with reduced
indentation):

   if(status != 0) {
     if(strcmp(filename, "./boot/grub/efi.img") == 0) {
       debconf_subst(debconf, "cdrom-checker/mismatch-efi", "FILE", filename);
       debconf_input(debconf, "high", "cdrom-checker/mismatch-efi");
     } else {
       debconf_subst(debconf, "cdrom-checker/mismatch", "FILE", filename);
       debconf_input(debconf, "high", "cdrom-checker/mismatch");
     }
   } else {
     debconf_input(debconf, "critical", "cdrom-checker/passed");
   }

A native speaker can probably find a better text and my guessing of the
inner code relations may be wrong, of course. Even the path
"./boot/grub/efi.img" is guessed from Ram Reddy's reported error message.


Have a nice day :)

Thomas