[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1011343: WISHLIST: Offical ALL-IN-ONE images?

On Thu, 16 Jun 2022 at 06:33, Thomas Schmitt <scdbackup@gmx.net> wrote:

> i wrote:
> > > https://dev.lovelyhq.com/libburnia/libisoburn/raw/branch/master/test/merge_debian_isos

> Nevertheless, it should be tested independently of me whether it can be
> tricked into destroying existing data on disk or leaving temporary files
> on disk.

Hi Thomas,

Thank you for your many valued contributions to Debian community!

As a casual observer, can I politely suggest a couple of things
regarding this script:

1) Consider checking the script using the https://www.shellcheck.net/
tool and looking at the warnings it gives. In particular iterating
over the output of 'ls' is not advisable.

2) Consider whether you do want your script to depend on bash, or
perhaps remove any bash-dependent features and make it
posix-compatible so that it can run in for example Debian's default
shell, dash. This can be checked by changing the first line of the
script to '#!/bin/sh' and checking again with the shellcheck tool.
I tried that and it looks like there are no obstacles to doing that,
just small changes.

Reply to: