[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#772691: marked as done (autorun.inf improvements)

Your message dated Mon, 20 Apr 2015 12:03:33 +0000
with message-id <E1YkAQH-00060R-M5@franck.debian.org>
and subject line Bug#772691: fixed in debian-cd 3.1.17
has caused the Debian Bug report #772691,
regarding autorun.inf improvements
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
772691: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=772691
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: debian-cd
Version: 3.1.16
Severity: minor
Tags: patch

In a Windows environment (and possibly others), a custom icon is
displayed for Ubuntu install ISOs/discs, taken from wubi.exe
(win32-loader.exe), instead of the default disc drive icon. This is not
the case for Debian install discs because they simply fail to include an
entry in the autorun.inf file pointing to the source of an icon to display.

I've attached a patch to fix this, based on the debian-cd master branch
(I hope that was the correct one).

Note that in the case of win32-loader not being present on the disk, the
autorun.inf file instead points to an autorun.bat file. A suitable icon
is not available here (as per [1] it must point to a .ico, .bmp, .exe,
or .dll file with a suitable icon don't forget, so /pics/logo-50.jpg is
definitely no good!). Thus to cover all cases, a copy of the logo must
be stored on the disk somewhere in .ico format (and my patch expanded
with the appropriate additional entries).

[1]
http://msdn.microsoft.com/en-us/library/windows/desktop/cc144200%28v=vs.85%29.aspx#icon

commit 4f8b0c1f7abd265af1819e1dc564a0b83978fcb5
Author: jnqnfe <jnqnfe@gmail.com>
Date:   Wed Dec 10 05:24:53 2014 +0000

    Improve autorun.inf

diff --git a/tools/boot/jessie/boot-hurd b/tools/boot/jessie/boot-hurd
index 884b374..bfbff40 100644
--- a/tools/boot/jessie/boot-hurd
+++ b/tools/boot/jessie/boot-hurd
@@ -85,6 +85,7 @@ if [ -f $CDDIR/README.html ]; then
        todos > $CDDIR/autorun.inf <<EOF
 [autorun]
 open=autorun.bat
+label=Install Debian GNU/Linux
 EOF
        todos > $CDDIR/autorun.bat <<EOF
 @echo Starting "README.html"...
diff --git a/tools/boot/jessie/boot-kfreebsd b/tools/boot/jessie/boot-kfreebsd
index 95a855d..7fb7979 100644
--- a/tools/boot/jessie/boot-kfreebsd
+++ b/tools/boot/jessie/boot-kfreebsd
@@ -99,6 +99,7 @@ if [ -f $CDDIR/README.html ]; then
        todos > $CDDIR/autorun.inf <<EOF
 [autorun]
 open=autorun.bat
+label=Install Debian GNU/Linux
 EOF
        todos > $CDDIR/autorun.bat <<EOF
 @echo Starting "README.html"...
diff --git a/tools/boot/jessie/boot-x86 b/tools/boot/jessie/boot-x86
index 9148e11..818e6cd 100644
--- a/tools/boot/jessie/boot-x86
+++ b/tools/boot/jessie/boot-x86
@@ -382,11 +382,24 @@ if [ -f boot$N/setup.exe ]; then
 	todos > $CDDIR/autorun.inf <<EOF
 [autorun]
 open=setup.exe
+icon=setup.exe,0
+label=Install Debian GNU/Linux
+
+[Content]
+MusicFiles=false
+PictureFiles=false
+VideoFiles=false
 EOF
 elif [ -f $CDDIR/README.html ]; then
 	todos > $CDDIR/autorun.inf <<EOF
 [autorun]
 open=autorun.bat
+label=Install Debian GNU/Linux
+
+[Content]
+MusicFiles=false
+PictureFiles=false
+VideoFiles=false
 EOF
 	todos > $CDDIR/autorun.bat <<EOF
 @echo Starting "README.html"...
diff --git a/tools/boot/wheezy/boot-hurd b/tools/boot/wheezy/boot-hurd
index da5014e..65646e3 100644
--- a/tools/boot/wheezy/boot-hurd
+++ b/tools/boot/wheezy/boot-hurd
@@ -81,6 +81,7 @@ if [ -f $CDDIR/README.html ]; then
        todos > $CDDIR/autorun.inf <<EOF
 [autorun]
 open=autorun.bat
+label=Install Debian GNU/Linux
 EOF
        todos > $CDDIR/autorun.bat <<EOF
 @echo Starting "README.html"...
diff --git a/tools/boot/wheezy/boot-kfreebsd b/tools/boot/wheezy/boot-kfreebsd
index 9d58e02..1af6f8e 100644
--- a/tools/boot/wheezy/boot-kfreebsd
+++ b/tools/boot/wheezy/boot-kfreebsd
@@ -93,6 +93,7 @@ if [ -f $CDDIR/README.html ]; then
        todos > $CDDIR/autorun.inf <<EOF
 [autorun]
 open=autorun.bat
+label=Install Debian GNU/Linux
 EOF
        todos > $CDDIR/autorun.bat <<EOF
 @echo Starting "README.html"...
diff --git a/tools/boot/wheezy/boot-x86 b/tools/boot/wheezy/boot-x86
index bf79d6d..70bf93f 100644
--- a/tools/boot/wheezy/boot-x86
+++ b/tools/boot/wheezy/boot-x86
@@ -370,11 +370,24 @@ if [ -f boot$N/setup.exe ]; then
 	todos > $CDDIR/autorun.inf <<EOF
 [autorun]
 open=setup.exe
+icon=setup.exe,0
+label=Install Debian GNU/Linux
+
+[Content]
+MusicFiles=false
+PictureFiles=false
+VideoFiles=false
 EOF
 elif [ -f $CDDIR/README.html ]; then
 	todos > $CDDIR/autorun.inf <<EOF
 [autorun]
 open=autorun.bat
+label=Install Debian GNU/Linux
+
+[Content]
+MusicFiles=false
+PictureFiles=false
+VideoFiles=false
 EOF
 	todos > $CDDIR/autorun.bat <<EOF
 @echo Starting "README.html"...

Attachment: logos.tar.bz2
Description: Binary data


--- End Message ---
--- Begin Message --- 
Source: debian-cd
Source-Version: 3.1.17

We believe that the bug you reported is fixed in the latest version of
debian-cd, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 772691@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Steve McIntyre <93sam@debian.org> (supplier of updated debian-cd package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 20 Apr 2015 12:36:57 +0100
Source: debian-cd
Binary: debian-cd
Architecture: source all
Version: 3.1.17
Distribution: unstable
Urgency: medium
Maintainer: Debian CD Group <debian-cd@lists.debian.org>
Changed-By: Steve McIntyre <93sam@debian.org>
Description:
 debian-cd  - Tools for building (Official) Debian CD set
Closes: 764676 767253 772691 777711 782299
Changes:
 debian-cd (3.1.17) unstable; urgency=medium
 .
   [ Steve McIntyre ]
   * Provide hashes for uncompressed Translation-* files, and remove the
     uncompressed versions from the output disc. Closes: #767253. Initial
     patch from Michael Vogt - thanks!
   * Add 586 kernels to replace 486 for i386 CDs
   * More tweaks for arm64 CD building
   * Change from -- to --- for kernel command line handling.
     Closes: #764676
   * Add minor support / bug fixes for i386 EFI.
   * Add fine-grained control over usage of BIOS and EFI boot on x86 CDs,
     needed for extra Mac CD builds.
   * update-cd: if we're doing torrents, make sure we include update CD
     checksums in bt-$type too.
   * Improve autorun.inf, make sure the disc icon displays. Closes: #772691
     Thanks to jnqnfe for initial patch, slightly tweaked.
   * Add rdnssd on disc 1 by default. Closes: #782299
   * Update included files from the setup repo in the contrib dir
 .
   [ Ben Hutchings ]
   * generate_di+k_list: Update kernel and related package lists for mips*
     Closes: #777711
 .
   [ Helge Deller ]
   * [alpha] fix unpacking aboot-base, copy versioned vmlinuz file correctly.
Checksums-Sha1:
 aa9004762ddfb90497cd97fb16b533a2f5485868 1711 debian-cd_3.1.17.dsc
 87003665f4f92014b88def6c99e236254013831e 725652 debian-cd_3.1.17.tar.xz
 f7fe516a6244e272962516fd6ae102fad5673bee 747282 debian-cd_3.1.17_all.deb
Checksums-Sha256:
 63b0eb9316c4fcbad28d018a1bdb3228f1992a0c375009cfcc739caa6565e731 1711 debian-cd_3.1.17.dsc
 ac9d3fd87994e8ca98524bed0d0703d01b9c03df10c153e8db721ab4e3530446 725652 debian-cd_3.1.17.tar.xz
 cd3cd7199531e9e99771a87292e72e233c9d4b6c4dd78fdbe26241e7ebacf1f5 747282 debian-cd_3.1.17_all.deb
Files:
 2293af02e816a84a200d7c7cf9e37ccc 1711 admin extra debian-cd_3.1.17.dsc
 3c6085450403aca472cfae712fd9a4cf 725652 admin extra debian-cd_3.1.17.tar.xz
 0f48f4b5fdd3446af96df796fa3e97c0 747282 admin extra debian-cd_3.1.17_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCAAGBQJVNOjIAAoJEFh5eVc0QmhOmrAP/RWqXYajqaknOYbhzVzgrgeD
XZfmg1ctkAneTin0Nb3APECmkt6bJ6AlC2iRECjaQTdMw+QhPHyIgoLt/myM+QSx
gJOML5geX0qABno6omvofxSgRO150mockTIFI7YZvcAJMMnxj3BYgzH5Ch1Ayy82
J8XEUG0/sjOKHaLg283ldIfib7NXwwoT2LGE9/D3VNcW/euCRmlBzoqLH5fClh9D
j+UNA1nWXmBCCwqai7pSrpUMSB2pu04E1R6t0ymtMPnlJE7MMm20NlIjxhX8sIWU
bN/CZ5Xb9Y5v6ht8Nn0Qnd7pbIF6ul0lQv8DrQujuQZUy6w17UuUEXT7sP//NltK
Yxk5zt6b5QVlWXEyQnXXdEQx2UIHmrelra5FFxXrSwMNkDJO3KNfTWST03HIFncE
1XdYjndn5iIJoX59SrKhqFmDbCKwmcOpUnHoIqEhVpW/HyM098DW2e/FGCr1WBG2
Y9+xNgG9T+Ie1FP8TdzRUDsYLyxA5WGS9XDoZRRJdjo8ZQFb7NyMqH9WBdmrMyaU
TmTBv+De3w8uXbymS0UfEmy1rL5ZqPEnCjq+W5/JX1wSWwSmp+vyQJTVEN6tags6
MHr/YJjeYSOGfaadnC71wbP6cKB/8l5Lz3qZ5Ll1Ccba05leZu6S7Jl54Km9XkWw
GRQjOpEnrGOELX6FqXvz
=DFDU
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: