[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#772691: Disc icon not displayed



Package: debian-cd
Version: 3.1.16
Severity: minor
Tags: patch

In a Windows environment (and possibly others), a custom icon is
displayed for Ubuntu install ISOs/discs, taken from wubi.exe
(win32-loader.exe), instead of the default disc drive icon. This is not
the case for Debian install discs because they simply fail to include an
entry in the autorun.inf file pointing to the source of an icon to display.

I've attached a patch to fix this, based on the debian-cd master branch
(I hope that was the correct one).

Note that in the case of win32-loader not being present on the disk, the
autorun.inf file instead points to an autorun.bat file. A suitable icon
is not available here (as per [1] it must point to a .ico, .bmp, .exe,
or .dll file with a suitable icon don't forget, so /pics/logo-50.jpg is
definitely no good!). Thus to cover all cases, a copy of the logo must
be stored on the disk somewhere in .ico format (and my patch expanded
with the appropriate additional entries).

[1]
http://msdn.microsoft.com/en-us/library/windows/desktop/cc144200%28v=vs.85%29.aspx#icon
commit 4f8b0c1f7abd265af1819e1dc564a0b83978fcb5
Author: jnqnfe <jnqnfe@gmail.com>
Date:   Wed Dec 10 05:24:53 2014 +0000

    Improve autorun.inf

diff --git a/tools/boot/jessie/boot-hurd b/tools/boot/jessie/boot-hurd
index 884b374..bfbff40 100644
--- a/tools/boot/jessie/boot-hurd
+++ b/tools/boot/jessie/boot-hurd
@@ -85,6 +85,7 @@ if [ -f $CDDIR/README.html ]; then
        todos > $CDDIR/autorun.inf <<EOF
 [autorun]
 open=autorun.bat
+label=Install Debian GNU/Linux
 EOF
        todos > $CDDIR/autorun.bat <<EOF
 @echo Starting "README.html"...
diff --git a/tools/boot/jessie/boot-kfreebsd b/tools/boot/jessie/boot-kfreebsd
index 95a855d..7fb7979 100644
--- a/tools/boot/jessie/boot-kfreebsd
+++ b/tools/boot/jessie/boot-kfreebsd
@@ -99,6 +99,7 @@ if [ -f $CDDIR/README.html ]; then
        todos > $CDDIR/autorun.inf <<EOF
 [autorun]
 open=autorun.bat
+label=Install Debian GNU/Linux
 EOF
        todos > $CDDIR/autorun.bat <<EOF
 @echo Starting "README.html"...
diff --git a/tools/boot/jessie/boot-x86 b/tools/boot/jessie/boot-x86
index 9148e11..818e6cd 100644
--- a/tools/boot/jessie/boot-x86
+++ b/tools/boot/jessie/boot-x86
@@ -382,11 +382,24 @@ if [ -f boot$N/setup.exe ]; then
 	todos > $CDDIR/autorun.inf <<EOF
 [autorun]
 open=setup.exe
+icon=setup.exe,0
+label=Install Debian GNU/Linux
+
+[Content]
+MusicFiles=false
+PictureFiles=false
+VideoFiles=false
 EOF
 elif [ -f $CDDIR/README.html ]; then
 	todos > $CDDIR/autorun.inf <<EOF
 [autorun]
 open=autorun.bat
+label=Install Debian GNU/Linux
+
+[Content]
+MusicFiles=false
+PictureFiles=false
+VideoFiles=false
 EOF
 	todos > $CDDIR/autorun.bat <<EOF
 @echo Starting "README.html"...
diff --git a/tools/boot/wheezy/boot-hurd b/tools/boot/wheezy/boot-hurd
index da5014e..65646e3 100644
--- a/tools/boot/wheezy/boot-hurd
+++ b/tools/boot/wheezy/boot-hurd
@@ -81,6 +81,7 @@ if [ -f $CDDIR/README.html ]; then
        todos > $CDDIR/autorun.inf <<EOF
 [autorun]
 open=autorun.bat
+label=Install Debian GNU/Linux
 EOF
        todos > $CDDIR/autorun.bat <<EOF
 @echo Starting "README.html"...
diff --git a/tools/boot/wheezy/boot-kfreebsd b/tools/boot/wheezy/boot-kfreebsd
index 9d58e02..1af6f8e 100644
--- a/tools/boot/wheezy/boot-kfreebsd
+++ b/tools/boot/wheezy/boot-kfreebsd
@@ -93,6 +93,7 @@ if [ -f $CDDIR/README.html ]; then
        todos > $CDDIR/autorun.inf <<EOF
 [autorun]
 open=autorun.bat
+label=Install Debian GNU/Linux
 EOF
        todos > $CDDIR/autorun.bat <<EOF
 @echo Starting "README.html"...
diff --git a/tools/boot/wheezy/boot-x86 b/tools/boot/wheezy/boot-x86
index bf79d6d..70bf93f 100644
--- a/tools/boot/wheezy/boot-x86
+++ b/tools/boot/wheezy/boot-x86
@@ -370,11 +370,24 @@ if [ -f boot$N/setup.exe ]; then
 	todos > $CDDIR/autorun.inf <<EOF
 [autorun]
 open=setup.exe
+icon=setup.exe,0
+label=Install Debian GNU/Linux
+
+[Content]
+MusicFiles=false
+PictureFiles=false
+VideoFiles=false
 EOF
 elif [ -f $CDDIR/README.html ]; then
 	todos > $CDDIR/autorun.inf <<EOF
 [autorun]
 open=autorun.bat
+label=Install Debian GNU/Linux
+
+[Content]
+MusicFiles=false
+PictureFiles=false
+VideoFiles=false
 EOF
 	todos > $CDDIR/autorun.bat <<EOF
 @echo Starting "README.html"...

Attachment: logos.tar.bz2
Description: Binary data


Reply to: