[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#740504: cdimage.debian.org: Released ISO images have invalid GPT tables



On Mon, Apr 07, 2014 at 03:55:44PM +0200, Thomas Schmitt wrote:
>Hi,
>
>> the bug in question is supposed to have existed in upstream until 1.3.4?
>
>No.
>It was introduced by 1.2.4 and fixed by 1.3.0.
>So the version in Debian testing should be ok.
>It's just that xorriso-1.3.6.pl01 is the newest upstream release,
>which i would of course like to see in Debian testing.
>
>The bug seems not to hamper booting.
>But it keeps partition editors from recognizing the GPT.
>gdisk for example says:
>  Found invalid GPT and valid MBR; converting MBR to GPT format.
>
>
>The bug is/was that the CRC number of the GPT header block was
>computed from all 512 bytes, rather than from the 92 bytes which
>actually bear information.
>
>The fix is tested since a year. At two occurences in
>libisofs/system_area.c, the number 512 needs to be replaced by 92:
>
>-     crc = iso_crc32_gpt((unsigned char *) buf, 512, 0);
>+     crc = iso_crc32_gpt((unsigned char *) buf, 92, 0);
>
>See
>  http://bazaar.launchpad.net/~libburnia-team/libisofs/scdbackup/revision/1071/libisofs/system_area.c
>
>If Debian decides to e.g. fix xorriso-1.2.6 on the debian-cd production
>machine, then it would be helpful to also update the timestamp in
>  xorriso/xorriso_timestamp.h
>to e.g. 
>  #define Xorriso_timestamP "2014.04.07.133000"
>in order to indicate the fixed program version in the Preprarer Id
>of the emerging ISO images.

Done. Apologies for the delay in getting to this, I've been totally
swamped with other stuff. New version of xorriso built and installed
on pettersson (the CD build machine) with

#define Xorriso_timestamP "2014.04.08.180000"

Please shout if you want me to change to another newer version, e.g. for the
hppa changes that you've been talking about elsewhere.

Other folks: could you please test the output of the next daily builds
and verify these work better for you?

-- 
Steve McIntyre, Cambridge, UK.                                steve@einval.com
"I suspect most samba developers are already technically insane... Of
 course, since many of them are Australians, you can't tell." -- Linus Torvalds


Reply to: