Bug#593629: debian-cd: GNU/kFreeBSD support
On Fri, Aug 20, 2010 at 03:38:07PM +0100, Steve McIntyre wrote:
> On Thu, Aug 19, 2010 at 07:58:14PM +0200, Aurelien Jarno wrote:
> >Package: debian-cd
> >Version: 3.1.3
> >Severity: normal
> >Tags: patch
> >
> >Hi,
> >
> >The patch below add support for GNU/kFreeBSD. It's a mix of support
> >for kfreebsd-amd64 and kfreebsd-i386 with bug fixes to support a "-"
> >in the architecture name.
> >
> >If you have any question, don't hesitate. If not, please apply this
> >patch for the next upload.
>
> All looks excellent, except:
Thanks for the review.
> >Index: data/squeeze/exclude-udebs
> >===================================================================
> >--- data/squeeze/exclude-udebs (révision 2043)
> >+++ data/squeeze/exclude-udebs (copie de travail)
> >@@ -134,6 +134,8 @@
> > kbd-udeb
> > console-setup-*
> > # Currently unused
> >+debian-ports-archive-keyring-udeb
> >+emdebian-archive-keyring-udeb
> > nbd-client-udeb
> > pwgen-udeb
> > # Eh?
>
> I don't understand why you're touching the generic exclude-udebs file
> here. Is this just another local change that's got caught up in your
> diff, or is this a generic change you think we should take anyway?
Oh yes, it's a generic change that should not have ended in this patch,
but I wanted to submit separately. I have reviewed the list of packages
that are excluded to compute the kfreebsd specific one, and noticed
these two packages. They are not necessary unless you install an
architecture hosted on embdebian or debian-ports, and even in that case
they should already be in the initrd.
> Once that's fixed, I'll commit your changes and also add support for
> the kfreebsd arches in the daily and weekly build scripts.
>
Thanks!
Aurelien
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
Reply to: