On Sun, 2009-08-09 at 11:32 +0200, Frans Pop wrote: > On Friday 07 August 2009, Ian Campbell wrote: > > diff --git a/installer/build/boot/x86/xen/xm-debian.cfg > > b/installer/build/boot/x86/xen/xm-debian.cfg index d1d78e7..7c3ff51 > > 100644 > > --- a/installer/build/boot/x86/xen/xm-debian.cfg > > +++ b/installer/build/boot/x86/xen/xm-debian.cfg > > The patch for this file introduces trailing whitespace in several places. > > > diff --git a/installer/build/config/amd64/cdrom-xen.cfg > > b/installer/build/config/amd64/cdrom-xen.cfg new file mode 100644 > > index 0000000..3f03e74 > > --- /dev/null > > +++ b/installer/build/config/amd64/cdrom-xen.cfg > > @@ -0,0 +1,13 @@ > > +TYPE=cdrom/gtk > > + > > +EXTRANAME=cdrom/xen/ > > + > > +MANIFEST-KERNEL = "kernel image for installing under Xen" > > +MANIFEST-INITRD = "initrd for installing under Xen" > > +MANIFEST-XENCFG = "example Xen configuration" > > + > > +TARGET = $(KERNEL) $(INITRD) xen_config > > +SYMLINK_KERNEL = ../vmlinuz > > +SYMLINK_INITRD = ../gtk/initrd.gz > > + > > +EXTRATARGETS = build_cdrom-gtk > > This should be 'EXTRATARGETS = build_cdrom_gtk' (underscore, not hyphen). Oh yes, strange that I didn't see an error. I guess I got lucky by using all_build so cdrom_gtk had always already been built or something. The amd64 netboot-xen which is already committed has the same problem -- I'll fix that right away. > I've been wondering if the cdrom-xen target should be built automatically > with the cdrom_isolinux target, but I guess that has both advantages and > disadvantages. In the end I'm OK with having it as a separate top-level > variant. I have no particular preference myself. Ian. -- Ian Campbell All's well that ends.
Attachment:
signature.asc
Description: This is a digitally signed message part