[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH 2/4] easy-build.sh: use getopts instead of rolling our own option parsing.



On Fri, 2009-08-07 at 13:33 +0100, Ian Campbell wrote:
> 
> I just tried it and it looks like the script is already not
> dash-ready:
> $ dash -x ./easy-build.sh -h
> + set -e
> + export CF=CONF.sh
> + . CONF.sh
> .: 1: CONF.sh: not found

I'm no expert but it looks like dash obeys $PATH when executing the ".".
The manpage doesn't mention this behaviour and bash doesn't seem to
follow it but "." is pretty hard to google for so I have looked up the
docs...

        $ PATH=.:$PATH ./easy-build.sh -h
        Usage: easy-build.sh [-h] [-d gnome|kde|lxde|xfce|light|all] BC|NETINST|CD|DVD [<ARCH> ...]

works for me. So does the following I've no idea if this is correct
analysis though...

--- a/easy-build.sh
+++ b/easy-build.sh
@@ -11,7 +11,7 @@ show_usage() {
 
 
 # Set configuration file to be used for the build and source it
-export CF=CONF.sh
+export CF=./CONF.sh
 . $CF
 export DEBIAN_CD_CONF_SOURCED=true
 unset UPDATE_LOCAL

-- 
Ian Campbell
Current Noise: Black Label Society - Bleed For Me

First law of debate:
	Never argue with a fool.  People might not know the difference.


Reply to: