[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#503722: marked as done (debian-cd: Comment "workaround for bug #402482" is WRONG)

Your message dated Sun, 2 Nov 2008 03:11:50 +0000
with message-id <20081102031150.GO14807@einval.com>
and subject line Re: Bug#503722: debian-cd: Comment "workaround for bug #402482" is WRONG
has caused the Debian Bug report #503722,
regarding debian-cd: Comment "workaround for bug #402482" is WRONG
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
503722: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=503722
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: debian-cd
Version: 3.0.2
Severity: important

In the file tools/make_disc_trees.pl in debian-cd-3.0.2, we see this:

sub md5_files_for_release {
    my ($md5, $size, $filename);

    $filename = $File::Find::name;

    # Recompress the Packages and Sources files; workaround for bug
    # #402482
    if ($filename =~ m/\/.*\/(Packages|Sources)$/o) {
        system("gzip -9c < $_ >$_.gz");
    }
... rest deleted

The function is invoked as:

    find (\&md5_files_for_release, ".");

The PROBLEM is that if Packages.gz exists, and is found BEFORE Packages,
you wind up with a corrupt Release file!  "find" does NOT sort its
files, so this can happen if you're unlucky.

-- System Information:
Debian Release: 4.0
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-6-686
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968) (ignored: LC_ALL set to C)

Versions of packages debian-cd depends on:
ii  apt                      0.6.46.4-0.1    Advanced front-end for dpkg
ii  bc                       1.06-20         The GNU bc arbitrary precision cal
ii  cpp                      4:4.1.1-15      The GNU C preprocessor (cpp)
ii  genisoimage              9:1.1.2-1       Creates ISO-9660 CD-ROM filesystem
ii  grep-dctrl               2.9.3           Grep Debian package information - 
ii  libcompress-zlib-perl    1.42-2          Perl module for creation and manip
ii  lynx                     2.8.5-2sarge2.2 Text-mode WWW Browser
ii  make                     3.81-2          The GNU version of the "make" util
ii  mkisofs                  9:1.1.2-1       Dummy transition package for genis
ii  perl [libdigest-md5-perl 5.8.8-7etch3    Larry Wall's Practical Extraction 
ii  tofrodos                 1.7.6-2         Converts DOS <-> Unix text files, 

Versions of packages debian-cd recommends:
pn  hfsutils               <none>            (no description available)
ii  netpbm                 2:10.0-11.1+etch1 Graphics conversion tools
ii  syslinux               1:3.31-4          Bootloader for Linux/i386 using MS

-- no debconf information

--- End Message ---
--- Begin Message --- 
On Sun, Nov 02, 2008 at 03:02:28AM +0000, Steve McIntyre wrote:
>On Tue, Oct 28, 2008 at 04:18:08PM -0400, David F. Skoll wrote:
>>
>> The Perl code relied on the "fact" that "find" would always find
>> Packages before Packages.gz, which happens to be true a lot of the
>> time, depending on how the files are created and how directory entries
>> are allocated, but is not true all of the time.
>
>Yup, I see that now. The answer is "yes, I was being dense". :-)
>
>I'm looking at applying your patch now.

But in fact there's no need - the very same bug was reported as
#423835 and fixed there already. debian-cd releases 3.0.3 and later
contain that fix.

Thanks for the bug report; I suggest you upgrade to get this and other
fixes.

-- 
Steve McIntyre, Cambridge, UK.                                steve@einval.com
  Getting a SCSI chain working is perfectly simple if you remember that there
  must be exactly three terminations: one on one end of the cable, one on the
  far end, and the goat, terminated over the SCSI chain with a silver-handled
  knife whilst burning *black* candles. --- Anthony DeBoer

--- End Message ---
Reply to: