[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH 5/6] Add code to load list.exclude before adding packages on CDs



Steve McIntyre <steve@einval.com> writes:

> On Tue, Feb 06, 2007 at 08:45:28AM -0200, Otavio Salvador wrote:
>>From: Otavio Salvador <otavio@ossystems.com.br>
>>
>>diff --git a/tools/list2cds b/tools/list2cds
>>index 78ec89f..427d814 100755
>>--- a/tools/list2cds
>>+++ b/tools/list2cds
>>@@ -107,6 +107,16 @@ if (not $nonus) {
>> 	}
>> }
>> 
>>+open (EXCLUDE_LIST, "< $exclude") || die "Can't open $exclude : $!\n";
>>+while (defined($_=<EXCLUDE_LIST>)) {
>>+	chomp;
>>+	next if m/^\s*$/;
>>+	next if $excluded{$_};
>>+	$excluded{$_} = 'list';
>>+	$count_excl++;
>>+}
>>+close EXCLUDE_LIST;
>>+
>> msg(1, "Statistics:
>> Number of packages: @{ [scalar(keys %packages)] }
>> Number of excluded: $count_excl of @{ [scalar(keys %excluded)] }
>
> Shouldn't be needed - make_disc_trees now does all the
> exclude/unexclude work, which was a deliberate choice. It needs to
> know what has been excluded in case you *un*exclude packages on later
> discs.

I'll check it again :-D But if it's true, then there's a lot of
exclude related code to be removed from here.

-- 
Otavio Salvador                  O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854         http://projetos.ossystems.com.br



Reply to: