[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

followup: jigdo template mdsum mismatch??



Looking at this portion of jigdo-mirror,

    # If possible, check md5sum of template data
    if test "$templateMD5"; then
        set -- `$jigdoFile md5sum --report=quiet "template"`
        if test "$1" = "$templateMD5"; then
            log "    Template checksum is correct"
        else
            log "    Error - template checksum mismatch"
            exitCode=1
            rm -f "image" "template"
            return 0
        fi
    else

$jigdoFile is "jigdo-file --cache=$tmpDir/jigdo-cache.db
--cache-expiry=1w --report=noprogress --no-check-files",

as usual (this is the default in jigdo-mirror). However when used with
--no-check-files jigdo-file does NOT produce any md5sum! Taking a
trace of jigdo-mirror I get this:

+ test OLshs7sHh08k63h8bLp8-Q   <-- This is the md5sum of the template,

++ jigdo-file --cache=/home/debian-cd-sync/alpha.cd/jigdo-cache.db --cache-expir
y=1w --report=noprogress --no-check-files md5sum --report=quiet template
+ set --
+ test '' = OLshs7sHh08k63h8bLp8-Q
+ log '    Error - template checksum mismatch'

This shows that jigdo-file is returning an empty checksum. Running
the command by hand does produce nothing, with an exit status of zero.
Removing the --no-check-files argument yields the correct checksum.

This is a bug in jigdo-file, for not ignoring the option when used
with a md5sum command, since the man page says "All options are
silently ignored if they are not applicable to the current command."



Reply to: