Re: [PATCH 6/6] Before resolve dependencies, add all packages listed on the task
On Thu, 08 Feb 2007, Otavio Salvador wrote:
> Steve McIntyre <steve@einval.com> writes:
>
> > On Tue, Feb 06, 2007 at 08:45:37AM -0200, Otavio Salvador wrote:
> >>From: Otavio Salvador <otavio@ossystems.com.br>
> >>
> >>Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> >
> > Hmmm. I'm not convinced by this one, either. It's a major decision to
> > change dependency ordering, and we expect dependency resolution to
> > work. What's the point of including packages in a task before all the
> > dependencies?
>
> Current code do not check the prefered packages of task before adding
> a dependency so, for example:
You're right this is a problem. But your approach doesn't look as the good
solution to that problem... you should keep the full task on the side (ie
a separate variable and not directly include it) and when you encounter an
OR depends, then check if one the components can be taken from the task
instead of arbitrarily.
Otherwise I fear you loose the fact that CD1 can be used independantly of
CD2, and so on...
Cheers,
--
Raphaël Hertzog
Premier livre français sur Debian GNU/Linux :
http://www.ouaza.com/livre/admin-debian/
Reply to: