[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#890571: libmseed-dev: libmseed.h misses unistd.h on non-Linux

Package: libmseed-dev
Version: 2.19.5-1
Severity: normal
Tags: upstream
User: debian-hurd@lists.debian.org
Usertags: hurd
Control: affects -1 src:mseed2sac

libmseed.h's #include directive for <unistd.h> is conditional on

  defined(LMP_LINUX) || defined(LMP_BSD) || defined(LMP_SOLARIS)

none of which winds up defined on the Hurd (or even kFreeBSD, seeing
how LMP_BSD is conditionalized).  Any halfway modern __unix system
(including in particular all Debian architectures) will have this
header; please #include it more widely.

As it stands, this conditionalization breaks the build of mseed2sac
for hurd-i386 [1] (admittedly not a release architecture):

  mseed2sac.c:543:9: warning: implicit declaration of function 'access'; did you mean 'acosl'? [-Wimplicit-function-declaration]
  mseed2sac.c:543:26: error: 'F_OK' undeclared (first use in this function)

Could you please take a look?


[1] https://buildd.debian.org/status/fetch.php?pkg=mseed2sac&arch=hurd-i386&ver=2.2%2Bds1-2&stamp=1518262290&raw=0

Aaron M. Ucko, KB1CJC (amu at alum.mit.edu, ucko at debian.org)
http://www.mit.edu/~amu/ | http://stuff.mit.edu/cgi/finger/?amu@monk.mit.edu

Reply to: