[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#836016: netcfg: Drop unnecessary loopback config in /etc/network/interfaces



Hi Martin,

Martin Pitt <mpitt@debian.org> (2016-08-30):
> Package: netcfg
> Version: 1.139
> 
> Hello,
> 
> netcfg still configures a "lo" (loopback) device in
> /etc/network/interfaces, although this hasn't been necessary since
> ifupdown 0.7.41 in 2013:
> 
>   https://anonscm.debian.org/cgit/collab-maint/ifupdown.git/commit/?id=2127aa19d9416

Thanks. Your patch looks rather sane at first glance.

I'm not sure what the status is WRT non-Linux ports so I've added bsd
and hurd people in cc.

Also, what about the /etc/networks file? (I've just discovered it while
grepping for "loopback" in the netcfg codebase.)

> Please drop it as this is unnecessary extra parsing work at boot. I
> attach an untested (only build-tested) initial patch. The main thing
> I'm not sure about is whether this actually needs to clear
> /etc/network/interfaces when NetworkManager is installed -- would
> anything write "real" interfaces to /e/n/i in this case?

I can't easily check right now.

> OOI, how can an updated netcfg be tested locally?

debcheckout debian-installer, put generated netcfg udebs below
build/localudebs, and build e.g. a netboot-gtk image (see wiki
for instructions); the resulting mini.iso should be using your
local packages (that doesn't work for all udebs since some are
loaded way later, over the network, but netcfg might be OK).

> In a more general vein, ifupdown creates an appropriate /e/n/i on package
> installation already. It would be nicer if netcfg would not completly
> overwrite this and instead just add files to /etc/network/interfaces.d/

I don't think I'm going to look into this part since I've little time at the
moment.



KiBi.

Attachment: signature.asc
Description: Digital signature


Reply to: