[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#762199: zfsutils: zpool import finds nothing



On 14:47, Steven Chamberlain wrote:
> ktrace revealed a openat64, stat64, close of each disk/partition
> without trying to read a ZFS disklabel from it.  It seemed to be taking
> an early exit from detection due to:
> 
>     if (statbuf.st_size < SPA_MINDEVSIZE) {
>         (void) close(fd);

That doesn't seem to trigger any bug on upstream FreeBSD 10.1-BETA2,
even though the stat st_size for a disk/partition device is 0...

Turns out that cddl/compat/opensolaris/sys/stat.h defines a special
fstat64 that additionally calls DIOCGMEDIASIZE if it is a character
device.  But on GNU/kFreeBSD we're calling the plain GNU libc fstat64.

Regards,
-- 
Steven Chamberlain
steven@pyro.eu.org


Reply to: