[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#756794: vsftpd: FTBFS on kfreebsd-*



tags + patch
user debian-bsd@lists.debian.org
usertags + kfreebsd
thanks

Hi,

On 20/08/14 16:38, Jörg Frings-Fürst wrote:
> There are no changes at sysdeputil.c between vsftpd/3.0.2-14 and
> vsftpd/3.0.2-15.

I see what happened:  kfreebsd-kernel-headers introduced a new
sys/capability.h which we did not have before.  vsftpd will use it in
preference to a dummyinc/sys/capability.h

You can see in dummyinc/sys/capability.h that it would otherwise #undef
VSF_SYSDEP_HAVE_LIBCAP.

vsftpd expects sys/capability.h will define cap_t, but only libcap has
that, our header does not.  I'm not sure what's right/wrong here.
libcap is a linux-any package currently but would conflict with this
FreeBSD kernel header otherwise.  (Why does libpcap put it in sys/?)

Either way, we don't seem to have libcap on GNU/kFreeBSD, and quoting
Ben Kaduk:
> It seems [libpcap] is the provider of the cap_t; there is no such concept in
> the base freebsd system.

I think it is appropriate to add the attached, along with the other
platform-specific configuration atop sysdeputil.c

Regards,
-- 
Steven Chamberlain
steven@pyro.eu.org
Description:
  Neither FreeBSD nor GNU/kFreeBSD have libpcap.  Avoid confusing
  sys/capability.h kernel header with libpcap's
Author: Steven Chamberlain <steven@pyro.eu.org>
Bug-Debian: http://bugs.debian.org/756794
Forwarded: no

--- a/sysdeputil.c
+++ b/sysdeputil.c
@@ -113,6 +113,10 @@
   #define VSF_SYSDEP_HAVE_SETPROCTITLE
 #endif
 
+#if defined(__FreeBSD_kernel__)
+  #undef VSF_SYSDEP_HAVE_LIBCAP
+#endif
+
 #if defined(__NetBSD__)
   #include <stdlib.h>
   #define VSF_SYSDEP_HAVE_SETPROCTITLE

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: