Re: Bug#757711: netcfg: promptly kills dhclient, deconfigures interface

[Steven Chamberlain <steven@pyro.eu.org>]

I hope someone can explain the intent of the code below from netcfg:
why are DHCP clients killed here?  Is it to avoid them clobbering a
manual hostname/domain setting?  And is that really an issue in
practice, with whatever DHCP client[s] we use now?

The other thing is, the whole idea of DHCP is that the client should
stay running, to renew/retain its lease and/or change IP if asked to.
And perhaps release the DHCP lease at the end of the install.  If on
Linux, udhcpc is killed off, it probably isn't doing any of those things
currently?

I'll be testing this change tomorrow to see if it helps on kfreebsd at
least:

--- a/dhcp.c
+++ b/dhcp.c
@@ -608,19 +608,18 @@ int netcfg_activate_dhcp (struct debconfclient *client, struct netcfg_interface
         case DOMAIN:
             if (!have_domain && netcfg_get_domain (client, domain))
                 state = HOSTNAME;
             else {
                 di_debug("Network config complete");
                 netcfg_write_common("", hostname, domain);
                 netcfg_write_loopback();
                 netcfg_write_interface(interface);
                 netcfg_write_resolv(domain, interface);
-                kill_dhcp_client();
                 stop_rdnssd();
 
                 return 0;
             }
             break;
 
         case HOSTNAME_SANS_NETWORK:
             if (netcfg_get_hostname (client, "netcfg/get_hostname", hostname, 0))
                 state = ASK_OPTIONS;

Regards,
-- 
Steven Chamberlain
steven@pyro.eu.org