[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#749502: mate-screensaver: gratuitous systemd-logind dependency



Package: mate-screensaver
Version: 1.8.0-3
Severity: important
Tags: patch

Hi,

mate-screensaver has a build dependency on libsystemd-login-dev,
but I notice it's not configured to use it at all:

https://buildd.debian.org/status/fetch.php?pkg=mate-screensaver&arch=i386&ver=1.8.0-3&stamp=1399305942:
> dh_auto_configure --parallel -- \
>		--disable-silent-rules \
>		--disable-static \
>		--with-xscreensaverdir=/usr/share/xscreensaver/config \
>		--with-xscreensaverhackdir=/usr/lib/xscreensaver \
>		--with-mit-ext \
>		--libexecdir=/usr/lib/ \
>		--with-console-kit \
>		--with-libnotify \
>		--without-systemd \
>		--enable-locking \
>		--with-gtk=2.0

> dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/mate-screensaver/usr/bin/mate-screensaver was not linked against libsystemd-login.so.0 (it uses none of the library's symbols)


Would you please consider ideally removing the
libsystemd-login-dev dependency if it's not absolutely needed.
That makes the package accessible to a subset of linux users who
will not be installing systemd (or GNOME) on their jessie systems.

Or if it is needed, please limit it to [linux-any] (see patch) so that
it can build on kfreebsd and possibly other arches.  (And if you
configure --with-systemd, do that only if DEB_HOST_ARCH_OS=linux).

Thanks!

-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'stable')
Architecture: kfreebsd-amd64 (x86_64)

Kernel: kFreeBSD 9.0-2-amd64-xenhvm
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
--- mate-screensaver-1.8.0/debian/control.orig	2014-05-05 15:27:09.000000000 +0100
+++ mate-screensaver-1.8.0/debian/control	2014-05-27 14:01:07.147671808 +0100
@@ -26,7 +26,7 @@
                x11proto-xf86vidmode-dev,
                libxxf86vm-dev,
                libgl1-mesa-dev | libgl1-mesa-swx11-dev,
-               libsystemd-login-dev,
+               libsystemd-login-dev [linux-any],
                libnotify-dev,
                libdconf-dev,
                mate-common,

Reply to: