[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#728139: brutefir: FTBFS on kfreebsd-i386: fftw_convolver.c:(.text+0x5288): undefined reference to `convolver_sse_convolve_add'

tags 728139 + patch
user debian-bsd@lists.debian.org
usertags 728139 kfreebsd


This happens because, only on Linux i386, `-msse` is enabled and so
function convolver_sse_convolve_add is compiled.

Is that allowed by Debian policy?  A real 386 or 486 may not be able to
run it.

If `-msse` is not enabled, the code fails to build instead (as seen on
kfreebsd-i386) unless the attached patch is used.

Steven Chamberlain
--- brutefir-1.0l/fftw_convolver.c     2013-10-06 12:45:49.000000000 +0100
+++ brutefir-1.0l/fftw_convolver.c     2014-01-28 21:39:53.950114660 +0000
@@ -264,7 +264,7 @@
     memcpy(_d, output_cbuf, n_fft * sizeof(real_t));
     switch (opt_code) {
-#if defined(__ARCH_IA32__) || defined(__ARCH_X86_64__)
+#if defined(__ARCH_X86_64__)
     case OPT_CODE_SSE:
    convolver_sse_convolve_add(input_cbuf, coeffs, output_cbuf,
                                    n_fft >> 3);

Reply to: