Re: openpty and kfreebsd
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi Petr,
Thank you very much the patch below, I've just tested it and can confirm
it works perfectly!
I shall now forward all the relevant kFreeBSD patches to the upstream
author for inclusion in the upstream source.
Regards,
Daniel Lintott
On 07/10/13 14:45, Petr Salinger wrote:
> Hi again,
>
> the openpty internally uses fork() and wait().
>
> And there is a problem with earlier "signal(SIGCHLD, SIG_IGN)", as
> wait returns ECHILD. Please, could you alter source by:
>
>
> --- src/hv.c~ 2013-10-07 15:11:54.000000000 +0200 +++ src/hv.c
> 2013-10-07 15:35:36.000000000 +0200 @@ -156,15 +156,16 @@ goto
> ret; } #endif - signal(SIGCHLD, SIG_IGN); -
> signal(SIGPIPE, SIG_IGN); - memset(vpcs_list, 0, MAX_DAEMONS *
> sizeof(struct list));
>
> if (openpty(&ptyfdm, &ptyfds, NULL, NULL, NULL)) { perror("Create
> pseudo-terminal"); goto ret; } + + signal(SIGCHLD, SIG_IGN);
> + signal(SIGPIPE, SIG_IGN); + fptys = fdopen(ptyfds, "w");
>
> rls = readline_init(50, 128);
>
>
> Petr
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with undefined - http://www.enigmail.net/
iQEcBAEBAgAGBQJSU+R6AAoJEMw/9yOWzAkJOj4IAJt3HLkD6Hdkoz6ZdwT4h6zp
Jigoj9GYqAjXvfR9Qczw9e9QX/vce0KQwZnsFbejVE+trftvO5Lg7by6xS4j4FeH
weXRoK4zU68KDGr9y0uLQPc3VkO1/4bFQ2EvMLBmjNgLhCm2tGQTmG1l5mbsNovc
1e6dQAY0AxbTzm3FbePB8EQzHwr2tRdAivGagMGbjKdEQIW7Yf2EiSvPZvcy21cD
Gt0TV9EDMvARQ5qMF0QefFRpEVU6kSzEiJGy3RiuYnkdhPyiDvu/O5118PocPkz7
7gqSPRdK8QV08xkeJPoRnQKDcGNtmSx7HfEnPg3pFpWMtC2p6sRygqPtU/iA5xE=
=djDx
-----END PGP SIGNATURE-----
Reply to: