[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#725071: xine-lib-1.2: FTBFS on kfreebsd (missing vaapi)



Control: tags -1 + patch

Hi,

I suspect VAAPI is not meant to be provided on kfreebsd.  Refer to
defaults of configure script below:

>         freebsd*|kfreebsd*)
>             default_enable_vidix=yes
>             default_enable_vdpau=yes
>             ;;

>         linux*)
>             default_enable_dxr3=yes
>             default_enable_fb=yes
>             default_enable_vidix=yes
>             default_enable_vdpau=yes
>             default_enable_vaapi=yes

The attached patch would omit VAAPI from dh_install on kfreebsd.
(kfreebsd-amd64 install file is hardlinked to the same as kfreebsd-i386)

I did try anyway to --enable-vaapi, but currently it fails for another
reason:

>   CC       xineplug_vo_out_vaapi_la-video_out_vaapi.lo
> video_out_vaapi.c: In function 'delay_usec':
> video_out_vaapi.c:585:5: error: implicit declaration of function 'get_ticks_usec' [-Werror=implicit-function-declaration]
>      then = get_ticks_usec();
>      ^

It may be simple enough to fix that, but I wouldn't go against
upstream's explicit choice without a good reason, and a way to test that
it really works and is useful.

Regards,
-- 
Steven Chamberlain
steven@pyro.eu.org
--- debian/rules.orig	2013-09-24 01:11:08.000000000 +0100
+++ debian/rules	2013-10-01 20:30:46.158318390 +0100
@@ -203,7 +203,7 @@
 # create install files for Debian GNU/kFreeBSD i386/amd64 by dropping
 # everything which is not available on those architectures.
 debian/libxine2-x.install.kfreebsd-i386: debian/libxine2-x.install
-	grep -v -e dxr3 $< >$@
+	grep -v -e dxr3 -e vaapi $< >$@
 
 debian/libxine2-misc-plugins.install.kfreebsd-i386: debian/libxine2-misc-plugins.install
 	grep -v -e dxr3 -e pvr -e v4l -e alsa -e dvb $< >$@

Reply to: