Re: suggested fix
On 20/06/12 22:09, Nicholas Bamber wrote:
> On 20/06/12 22:04, Steven Chamberlain wrote:
>> This debdiff doesn't address the main point of my original mail:
>> sockaddr_dl and net/if_dl.h are not (k)FreeBSD-specific, so a test for
>> FreeBSD || FreeBSD_kernel would not be appropriate.
You still didn't address that in your reply.
> As I understood it you wanted the build to fail on Hurd so everyone
> would know there was an AF_LINK/sockaddr_dl bug on Hurd.
If there is really an issue in GNU/Hurd, such as a missing header, then
yes, I'd prefer that the build fails[1], rather than add a workaround
(with whatever consequences) to this package (which someone would have
to remember to remove at the appropriate time, to restore the intended
functionality).
As it happens, if a workaround for the current FTBFS is all that's
needed, the attached diff would be able to do that very cleanly.
[1] Just to make sure this isn't the cause of any confusion: FTBFS on
GNU/Hurd is not a blocker for Wheezy, testing migration or transitions.
Regards,
--
Steven Chamberlain
steven@pyro.eu.org
--- pmacct-0.14.0.orig/src/isis/sockunion.c 2012-03-28 18:46:09.000000000 +0100
+++ pmacct-0.14.0/src/isis/sockunion.c 2012-06-20 22:32:29.672205632 +0100
@@ -596,6 +596,7 @@
return NULL;
}
+#if 0
/* Print sockunion structure */
static void __attribute__ ((unused))
sockunion_print (union sockunion *su)
@@ -634,6 +635,7 @@
break;
}
}
+#endif
#ifdef ENABLE_IPV6
static int
Reply to: