[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#692739: gdm3/experimental: FTBFS on kfreebsd-any, needs porting and testing



Package: gdm3
Version: 3.6.0-1
Severity: serious
Justification: fails to build from source (but built successfully in the past)
Tags: experimental upstream
Forwarded: https://bugzilla.gnome.org/show_bug.cgi?id=687921

>From the buildd log:
> gdm-session.c: In function 'credentials_get_unix_pid':
> gdm-session.c:989:2: error: #error "platform not supported, need mechanism to detect pid of connected process"

The #elif defined (__FreeBSD__) case should be
#elif defined (__FreeBSD__) || defined (__FreeBSD_kernel__) for Debian
(GNOME #687921).

Also, that code path is clearly broken, because it uses
G_CREDENTIALS_TYPE_OPENBSD_SOCKPEERCRED, whereas I expect it should be using
G_CREDENTIALS_TYPE_FREEBSD_CMSGCRED on FreeBSD. (Also GNOME #687921.)

This leads me to believe that it has never been tested, so I'm not going
to do anything about this bug until/unless someone tests it on kFreeBSD and
confirms that the resulting gdm3 actually works. (This is the version
in experimental, so there's no particular urgency.) If it does work,
please tell upstream.

Alternatively, someone could implement g_credentials_get_unix_pid(),
which clearly ought to exist anyway, and would move the problem into GIO.
(GNOME #687920.)

This is also a problem on Hurd, but as far as I understand it, Hurd doesn't
support credentials-passing at all; gdm3 appears to require
credentials-passing, so it's right that it continue to FTBFS on Hurd. From
<https://www.gnu.org/software/hurd/open_issues/sendmsg_scm_creds.html>
it appears that if Hurd ever gets credentials-passing, it'll be
FreeBSD-style SCM_CREDS.

    S


Reply to: