[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#679055: istgt: Add support to reload the istgt.conf file.

Hi Arno,

On Tue, 2012-06-26 at 11:11 +0200, Arno Töll wrote:
> On 26.06.2012 06:07, andrew@etc.gen.nz wrote:
> > The attached patch, ported from FreeBSD, adds a refresh command to
> > istgtcontrol to allow telling istgt to reload istgt.conf and update
> > the running configuration, all without restarting the daemon.
> Did you contact the upstream author? As far as I'm informed he was
> planning to add reload LUN reload support to the upcoming 0.5 series but
> I didn't hear since.

I haven't contacted the upstream author, two reasons, 1) I was hoping
that the FreeBSD guys had, and 2) I wanted to make sure I submitted the
patch to the BTS with at least a few days before the wheezy freeze!

> Anyway, thanks for your patch which looks quite good at a first glance.
> I'll review and test later so that it will end in Wheezy before the freeze.

Thank you, that'd be awesome.

A couple of things I've noticed that are missing (in my opinion), no
SIGHUP support in the daemon and to have a LogicalUnit refresh you need
to change the name of it (this is arguably understandable) and the other
feature that would be nice to have is to change the advertised size of
the block device if it changes.

But I didn't actually write the patch and I'm not about to delve in the
bowels of the code!


Andrew Ruthven
Wellington, New Zealand
At home: andrew@etc.gen.nz |   linux.conf.au 2013
                           | Come join the party...
                           |  http://linux.conf.au

Attachment: signature.asc
Description: This is a digitally signed message part

Reply to: