Re: Bug#670412: geli init script fails if /etc/default/geli is unconfigured

[Steven Chamberlain <steven@pyro.eu.org>]

On 25/04/12 12:52, Stefan Bühler wrote:
> Setting up geom (9.0+ds1-3) ...
> Starting GELI subsystem...UNCONFIGURED. See /etc/default/geli ... failed!
> invoke-rc.d: initscript geli, action "start" failed.
> dpkg: error processing geom (--configure):
>  subprocess installed post-installation script returned error exit status 1

Hi,

The initscript will need to return zero exit status in this case (Debian
policy seems to allow that, despite contradictory LSB policy).


But there is still a choice in how this can be displayed:

1. With existing log_failure_msg:

Starting GELI subsystem... UNCONFIGURED. See /etc/default/geli ... failed!

2. With log_success_msg (with implicit log_end_msg 0 = 'ok') :

Starting GELI subsystem... UNCONFIGURED. See /etc/default/geli.

3. With log_warning_msg (with implicit log_end_msg 255 = 'warning') :

Starting GELI subsystem... UNCONFIGURED. See /etc/default/geli (warning).

And if we get the fancy new lsb-base (4.1+Debian0+fancy1) in Wheezy,
these would be preceded by [FAIL], [ ok ] or [warn] coloured
red/green/yellow respectively.


I think I prefer option 3, and also fixing the screaming capital
letters.  That seems the best way to communicate a not-quite-successful
status, so the administrator is encouraged to either properly configure
it or remove it.

Regards,
-- 
Steven Chamberlain
steven@pyro.eu.org