[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#667836: FTBFS on kfreebsd-amd64

retitle 667836 FTBFS on kfreebsd-*

On 06/04/12 22:55, Robert Millan wrote:
> The glib init code is completely obsolete.  g_thread_supported() is now a stub
> which always returns 1, so the first assertion doesn't make sense.


Was just about to send you an identical diff :)

Yes it makes sense to remove those (and it fixes the FTBFS for me on
kfreebsd-i386).  The g_assert was there to check that threading was
already initialised;  if that was ever happening it would have been
causing assertion failures so I assume it's safe to remove.

Also the if(...) g_thread_init() at the end was unnecessary as the
documentation states g_type_init() will do that anyway since 2.24 and we
have that since Squeeze.

Steven Chamberlain

Reply to: