Re: Bug#653771: FTBFS on kfreebsd-* due to -Wformat-security
On 30/12/11 21:49, Steven Chamberlain wrote:
> ntp is now failing to build on the kfreebsd-* arches.
Argh! I had the wrong version of the source package. Most of the fixes
in my last mail are already applied (as per #542721, #627403) -- but
there are two places where some (apparently kfreebsd-specific) code was
not covered by Colin Watson's existing format-security.patch
This explains why build failures occurred only on kfreebsd arches.
My new patch (attached) fixes only those parts, and I am now able to
build successfully on kfreebsd-i386.
Thanks!
Regards,
--
Steven Chamberlain
steven@pyro.eu.org
Index: ntp-4.2.6.p3+dfsg/lib/isc/unix/ifiter_sysctl.c
===================================================================
--- ntp-4.2.6.p3+dfsg.orig/lib/isc/unix/ifiter_sysctl.c 2010-12-25 09:40:35.000000000 +0000
+++ ntp-4.2.6.p3+dfsg/lib/isc/unix/ifiter_sysctl.c 2011-12-30 20:30:25.000000000 +0000
@@ -272,10 +272,11 @@
return (ISC_R_SUCCESS);
} else {
- printf(isc_msgcat_get(isc_msgcat, ISC_MSGSET_IFITERSYSCTL,
- ISC_MSG_UNEXPECTEDTYPE,
- "warning: unexpected interface list "
- "message type\n"));
+ fprintf(stdout, "%s",
+ isc_msgcat_get(isc_msgcat, ISC_MSGSET_IFITERSYSCTL,
+ ISC_MSG_UNEXPECTEDTYPE,
+ "warning: unexpected interface list "
+ "message type\n"));
return (ISC_R_IGNORE);
}
}
Index: ntp-4.2.6.p3+dfsg/ntpd/refclock_oncore.c
===================================================================
--- ntp-4.2.6.p3+dfsg.orig/ntpd/refclock_oncore.c 2010-12-25 09:40:34.000000000 +0000
+++ ntp-4.2.6.p3+dfsg/ntpd/refclock_oncore.c 2011-12-30 20:37:33.000000000 +0000
@@ -4058,7 +4058,7 @@
snprintf(Msg, sizeof(Msg), "ONCORE[%d]: %s", instance->unit,
msg);
- syslog(log_level, Msg);
+ syslog(log_level, "%s", Msg);
i = strlen(msg);
Reply to: