Re: Bug#648361: uninstallable on kfreebsd-amd64
2011/11/15 Ola Lundqvist <ola@inguza.com>:
>> Notice how my patch enables "-DUSER_PPP" in CFLAGS. This has a
>> significant impact on the codepaths, most likely disabling the
>> kernel-specific code you had in mind.
>
> When looking deeper into this it looks like your change is only
> applicable to GNU/kFreeBSD, right?
Yes. Probably better to use:
ifneq (, $(filter FreeBSD GNU/kFreeBSD, $(UNAME)))
or similar.
> However I have one note on the patch. I see that you use
> some patches/series function. I have not used that before. I have simply
> applied the patches in the old fashioned way. Is it ok if I continue
> that way? I find the new patch mechanism a bit too slow and not very
> fail safe.
Of course, it's your package :-)
--
Robert Millan
Reply to: