Re: [Gkrellm] Re: Bug#638335: gkrellm: FTBFS(kfreebsd): patch for building on kfreebsd
Hi!
Stefan Gehn <stefan@gkrellm.srcbox.net> writes:
> --- gkrellm-2.3.5.orig/src/sysdeps/freebsd.c
> +++ gkrellm-2.3.5/src/sysdeps/freebsd.c
> @@ -1395,7 +1399,8 @@ static VoltDefault voltdefault0[] =
> };
>
> #include <dirent.h>
> -#include <machine/cpufunc.h>
> +/*#include <machine/cpufunc.h>*/
> +#include <sys/io.h>
> #if __FreeBSD_version >= 500042
> #include <dev/smbus/smb.h>
> #elif __FreeBSD_version >= 300000
>
>
> Why is the cpufunc.h include commented out? Is it needed for other
> systems and if not why not remove the include altogether?
That's because I was a bit unsure whether this is actually correct
(clean). Commenting out still isn't the right thing of course, maybee
someone from debian-bsd@ has a idea? [0] Without changing it the build
fails here trying to link gkrellm with
sysdeps-unix.o: In function `get_data':
/var/tmp/gkrellm-2.3.5/src/sysdeps/freebsd.c:1439: undefined reference to `outb'
/var/tmp/gkrellm-2.3.5/src/sysdeps/freebsd.c:1440: undefined reference to `inb'
Regards
Christoph
[0] This has already been built with -O2 fwiw
--
9FED 5C6C E206 B70A 5857 70CA 9655 22B9 D49A E731
Debian Developer | Lisp Hacker | CaCert Assurer
Reply to: