Bug#636389: ntop: FTBFS(kfreebsd): needs __FAVOR_BSD also on other GLIBC targets
Package: src:ntop
Version: 3:4.0.3+dfsg1-3
Severity: important
Tags: patch
Justification: fails to build from source (but built successfully in the past)
Hi!
Your package failed to build on kfreebsd as the configure script checks
os but does not have a case for kfreebsd. Later in the build it fails as
the networking usees BSD 'struct tcphdr' (and similar for UDP)
definitions which require __FAVOR_BSD to be defined. I've fixed both
with
--- ntop-4.0.3+dfsg1.orig/configure.in
+++ ntop-4.0.3+dfsg1/configure.in
@@ -427,7 +427,7 @@ case "${target}:${CC}" in
echo "* This appears to be ${DEFINEOS} (MacOSX)"
;;
- *-*-freebsd*:* )
+ *-*-*freebsd*:* )
DEFINEOS="FREEBSD"
RELEASE=`utils/linuxrelease --release | sed -e 's/\.//' -e 's/-.*$//g'`
echo "* This appears to be ${DEFINEOS} ${RELEASE}"
--- ntop-4.0.3+dfsg1.orig/ntop.h
+++ ntop-4.0.3+dfsg1/ntop.h
@@ -80,7 +80,7 @@ ntop.h
#endif
#endif
-#ifdef LINUX
+#ifdef __GLIBC__
/*
* This allows to hide the (minimal) differences between linux and BSD
*/
@@ -114,7 +114,7 @@ ntop.h
#endif
#define _THREAD_SAFE
-#if defined(__linux__)
+#if defined(__GLIBC__)
#ifndef _GNU_SOURCE
#define _GNU_SOURCE
#endif
which makes ntop build. Installing failed for me as (at least in default
debconf priority) ntop seems to assume eth0 to be present if it wasn't
installed previously and if there is no eth0 fails in postinst.
After adapting the config it installed fine and seems to work from some
quick checks.
I'm not totally sure setting kFreeBSD to FreeBSD in configure is the
best way depending on how much assumptions based on this switch consider
userland (glibc) and how much actually depend on the kernel but the
FreeBSD way works and these flags don't seem to be widely used anyway.
Regards
Christoph
If you have further questions please mail debian-bsd@lists.debian.org
--
9FED 5C6C E206 B70A 5857 70CA 9655 22B9 D49A E731
Debian Developer | Lisp Hacker | CaCert Assurer
A. Because it breaks the logical sequence of discussion
Q. Why is top posting bad?
Reply to: