Re: Bug#630206: libnss-myhostname: FTBFS: fatal error: asm/types.h: No such file or directory
On Fri, 17.06.11 11:16, Robert Millan (rmh@debian.org) wrote:
>
> 2011/6/17 Joachim Breitner <nomeata@debian.org>:
> > I have applied and uploaded this patch to the Debian package. If there
> > will be a better patch that addresses the ifindex issue, I’ll be happy
> > to apply that as well.
>
> Thanks Joachim. I may have a look at improving this, though not right now.
>
> > BTW, Lennart, I am also applying the attached patch because
> > HOST_NAME_MAX does not always exist. If you could include that patch in
> > the next version as well, that would be great, as it further reduces the
> > difference to the Debian version.
>
> GNU/kFreeBSD has MAXHOSTNAMELEN, so you could just use this
> macro if HOST_NAME_MAX isn't defined. Please don't hardcode such
> limits unnecessarily.
Is there any good reason why kfreebsd does not set HOST_NAME_MAX but
MAXHOSTNAMELEN? Or is it just to annoy people and to litter other
people's code with ifdef orgies?
HOST_NAME_MAX is POSIX, so I see really no reason to add some compat
kludgery, for MAXHOSTNAMELEN.
http://pubs.opengroup.org/onlinepubs/009695399/basedefs/limits.h.html
Fix your glibc first. And if there's a really good reason not to, then
at least supply me with a patch, because otherwise I don't care.
Lennart
--
Lennart Poettering - Red Hat, Inc.
Reply to: