Re: Testing new getpt(3) and posix_openpt(3) implementation
On Thu, 2011-06-09 at 11:05:28 +0200, Petr Salinger wrote:
> >>or run tested the code, so if someone with an eglibc
> >>build-tree around could test the attached patch (against the
> >>glibc-ports tree) that would be pretty helpful
> >
> >With slight modification in progress.
Thanks for the building and testing!
> There are failures in testsuite, at least ptsname.c have to be
> updated too.
Ah right, had a small change for that one, but as there seemed to be
more changed needed there I didn't include it, was not suspecting it
would cause test suite failures. :) Attached now.
Although the line with:
p[0] = 't';
seems a bit suspicious, but then I've not analyzed the function in
depth.
thanks,
guillem
Index: kfreebsd/ptsname.c
===================================================================
--- kfreebsd/ptsname.c (revision 3434)
+++ kfreebsd/ptsname.c (working copy)
@@ -26,8 +26,11 @@
#include <unistd.h>
+/* Directory where we can find the slave pty nodes. */
+#define _PATH_DEVPTS "/dev/pts/"
+
/* Static buffer for `ptsname'. */
-static char buffer[sizeof (_PATH_TTY) + 2];
+static char buffer[sizeof (_PATH_DEVPTS) + 20];
/* Return the pathname of the pseudo terminal slave associated with
Reply to: