Bug#559398: goffice0.4: FTBFS on GNU/kFreeBSD: headers/includes issues
Package: goffice0.4
Version: 0.4.2-4.1
Severity: important
Tags: patch
User: debian-bsd@lists.debian.org
Usertags: kfreebsd
Hi,
your package FTBFS on GNU/kFreeBSD this way:
| cc -Wl,-z,defs -Wl,-O1 -Wl,--as-needed -L/usr/X11R6/lib -DHAVE_CONFIG_H -I. -I../../../goffice/gtk -I../../goffice -I../../goffice -I../.. -I../../.. -D_REENTRANT -DORBIT2=1 -pthread -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libgsf-1 -I/usr/include/libxml2 -I/usr/include/pango-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/directfb -I/usr/include/libpng12 -I/usr/include/libart-2.0 -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/libglade-2.0 -I/usr/include/libgnomeprint-2.2 -I/usr/include/gconf/2 -I/usr/include/orbit-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/libgnomeui-2.0 -I/usr/include/gnome-keyring-1 -I/usr/include/libgnome-2.0 -I/usr/include/libbonoboui-2.0 -I/usr/include/libgnomecanvas-2.0 -I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include -I/usr/include/libbonobo-2.0 -I/usr/include/bonobo-activation-2.0 -I/usr/include/gail-
1.0 -DGOFFICE_COMPILATION -Wall -g -O2 -DG_DISABLE_DEPRECATED -DPANGO_DISABLE_DEPRECATED -DGDK_PIXBUF_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED -DGDK_MULTIHEAD_SAFE -DLIBGLADE_DISABLE_DEPRECATED -DGNOME_DISABLE_DEPRECATED -DBONOBO_DISABLE_DEPRECATED -DBONOBO_UI_DISABLE_DEPRECATED -Wall -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wno-sign-compare -ansi -pedantic -Wsign-compare -Wpointer-arith -Wnested-externs -Wchar-subscripts -Wwrite-strings -Wdeclaration-after-statement -Wmissing-noreturn -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wformat -Wmissing-format-attribute -Wno-pointer-sign -D_POSIX_SOURCE -D_BSD_SOURCE -MT goffice-gtk.lo -MD -MP -MF .deps/goffice-gtk.Tpo -c ../../../goffice/gtk/goffice-gtk.c -fPIC -DPIC -o .libs/goffice-gtk.o
| In file included from /usr/include/gtk-2.0/gtk/gtk.h:228,
| from /usr/include/libglade-2.0/glade/glade-xml.h:26,
| from ../../../goffice/gtk/goffice-gtk.h:23,
| from ../../../goffice/gtk/goffice-gtk.c:22:
| /usr/include/gtk-2.0/gtk/gtkitemfactory.h:47: warning: function declaration isn't a prototype
| In file included from /usr/include/sys/stat.h:107,
| from /usr/include/glib-2.0/glib/gstdio.h:26,
| from ../../../goffice/gtk/goffice-gtk.c:32:
| /usr/include/bits/stat.h:198: error: expected ')' before 'dev'
| /usr/include/bits/stat.h:199: error: expected ')' before 'dev'
| ../../../goffice/gtk/goffice-gtk.c: In function 'cb_parent_mapped':
| ../../../goffice/gtk/goffice-gtk.c:210: warning: ISO C forbids passing argument 6 of 'g_signal_handlers_disconnect_matched' between function pointer and 'void *'
| make[4]: *** [goffice-gtk.lo] Error 1
At first glance, it looks like it could be a bug in the headers since
dev_t is declared through sys/types.h, which probably should be included
prior to using it in a prototype.
I'm opening a bug against goffice0.4 since it triggers this bug, and
since the attached patch makes it build fine. That probably should be
considered a workaround, and only applied if -bsd@ folks (in Cc:) think
it is actually not a bug in the headers.
Mraw,
KiBi.
--- a/goffice/gtk/goffice-gtk.c
+++ b/goffice/gtk/goffice-gtk.c
@@ -18,6 +18,7 @@
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301
* USA
*/
+#include <sys/types.h>
#include <goffice/goffice-config.h>
#include "goffice-gtk.h"
Reply to: